----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60532/#review179537 -----------------------------------------------------------
Ship it! I've committed the patch on master. Thanks David - Apoorv Naik On June 29, 2017, 10:03 a.m., David Radley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60532/ > ----------------------------------------------------------- > > (Updated June 29, 2017, 10:03 a.m.) > > > Review request for atlas, Madhan Neethiraj and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > ATLAS-1904. I have cleaned the code up in the validation logic to resolve > this issue. I have refactored the junit so the names are more intuitive and > it tests this case. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java > 49ead6e39e623a617cd3c90405bb41a348f79624 > intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java > f85cf35cc229c9e4b3e54984ae21a9a312cebd96 > intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java > 41aac8fb976f15c33765d91f5c2f973b78b232a7 > > > Diff: https://reviews.apache.org/r/60532/diff/1/ > > > Testing > ------- > > Ran junits and created a composition relationshipDef as expected. > > > Thanks, > > David Radley > >
