> On June 27, 2017, 9:11 a.m., David Radley wrote: > >
Please ignore the 60747 review (created by mistake). This review (58422) is the only one relevant to ATLAS-1733. > On June 27, 2017, 9:11 a.m., David Radley wrote: > > distro/src/bin/atlas_stop.py > > Lines 82 (patched) > > <https://reviews.apache.org/r/58422/diff/2/?file=1708250#file1708250line82> > > > > formatting error introduced in the fix I rebased and rebuilt the patch - new review is https://reviews.apache.org/r/60747/ - Graham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58422/#review178961 ----------------------------------------------------------- On May 4, 2017, 10:52 a.m., Graham Wallis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58422/ > ----------------------------------------------------------- > > (Updated May 4, 2017, 10:52 a.m.) > > > Review request for atlas and David Radley. > > > Repository: atlas > > > Description > ------- > > On Windows there is no SIGKILL in the python signal library, so attempting to > import SIGKILL causes a fatal error. > This change introduces a platform switch that avoids trying to import SIGKILL > and if the 30sec timeout expires > it avoids attempting to use SIGKILL, instead using SIGTERM as the os.kill() > function on Windows will terminate > the process and should be as severe as a SIGKILL (kill -9) on a *nix system. > > > Diffs > ----- > > distro/src/bin/atlas_stop.py a25d25aee599e7cc9ca3caaff8ff7f11b7e0c789 > > > Diff: https://reviews.apache.org/r/58422/diff/2/ > > > Testing > ------- > > Manually tested > > > Thanks, > > Graham Wallis > >
