----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60852/ -----------------------------------------------------------
(Updated July 14, 2017, 10:48 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian. Changes ------- Search code structure has changed from SolrStep and GremlinStep => FullTextProcessor, EntityProcessor, ClassificationProcessor These can be chained one after other and internally each determine whether to execute indexQuery or regular graph query. PipelineContext => SearchContext : Is responsible for determining the order of the processors as well Bugs: ATLAS-1947 https://issues.apache.org/jira/browse/ATLAS-1947 Repository: atlas Description ------- The search result will now include the following 1. guid -> referredEntity 2. Any valid attribute found in the search filter will be included for each entity in the result Diffs (updated) ----- intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java 9513dcb1 intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 30855dcf repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java 030a9577 repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java PRE-CREATION repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 5068fa5f repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java PRE-CREATION repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java PRE-CREATION repository/src/main/java/org/apache/atlas/discovery/GremlinStep.java 1056b3ef repository/src/main/java/org/apache/atlas/discovery/SearchContext.java PRE-CREATION repository/src/main/java/org/apache/atlas/discovery/SearchPipeline.java 0f91b2d1 repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java PRE-CREATION repository/src/main/java/org/apache/atlas/discovery/SolrStep.java 6a5dd5ae repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 4ac00a32 repository/src/main/java/org/apache/atlas/util/SearchTracker.java 15a8c203 repository/src/test/java/org/apache/atlas/TestModules.java d0da0303 webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 1a9f57a3 webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java dde300e2 Diff: https://reviews.apache.org/r/60852/diff/3/ Changes: https://reviews.apache.org/r/60852/diff/2-3/ Testing ------- mvn clean package runs successfully Thanks, Apoorv Naik