-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60970/#review180928
-----------------------------------------------------------


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java
Lines 484 (patched)
<https://reviews.apache.org/r/60970/#comment256274>

    It will be good to handle this while reading from vertex as well - in 
toRelationshipDef(vertex) below, so that null value in the store gets mapped to 
NONE.


- Madhan Neethiraj


On July 19, 2017, 2:26 p.m., David Radley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60970/
> -----------------------------------------------------------
> 
> (Updated July 19, 2017, 2:26 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1901: Tolerate no propogatetags on Relationshipdef
> 
> 
> Diffs
> -----
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java
>  ddf0af9abc5f07c355043e7aff54bfaae1323814 
> 
> 
> Diff: https://reviews.apache.org/r/60970/diff/1/
> 
> 
> Testing
> -------
> 
> Ran unit tests.
> I looked into creating a unit test - but this would have involved mocking 
> Vertex or the equivalent whcih seemed overkill for this small change.
> Created a relationshipDef without propogatetags set. Without the fix it 
> errors - with the fix it works producing a relationshipDef with propogateTags 
> = NONE.
> 
> 
> Thanks,
> 
> David Radley
> 
>

Reply via email to