-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60857/
-----------------------------------------------------------
(Updated July 19, 2017, 6:34 p.m.)
Review request for atlas, Ayub Pathan and Madhan Neethiraj.
Changes
-------
Updates include:
- Addressed review comments.
- Updated unit tests.
Bugs: ATLAS-1950
https://issues.apache.org/jira/browse/ATLAS-1950
Repository: atlas
Description
-------
**Background**
Existing import transforms expects that the user specify each type and
attribute name that needs to be transformed. This may cause large number of
transform enumerating individual types to be specified. Specifying individual
transforms may be tedious and perhaps error prone.
**Solution**
This feature improves on that case by allowing user to specify super types.
That way the sub types of that type will automatically get the transform(s)
applied.
**Implementation**
User can now specify transforms like:
```javascript
{
"options": {
"transforms": "{ \"Asset\": { \"qualifiedName\": [
\"replace:@cl1:@cl2\" ] } }"
}
}
```
At runtime, the subtypes of this type are enumerated. The attribute and
tranform map of the super type are now associated with all the sub-types.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java
92217178
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransforms.java
63e53c50
repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
404225c2
repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsTest.java
ccedeb14
Diff: https://reviews.apache.org/r/60857/diff/2/
Changes: https://reviews.apache.org/r/60857/diff/1-2/
Testing
-------
**Unit tests**
Unit test verifying this behavior were added.
**Functional tests**
Regular imports were run.
Thanks,
Ashutosh Mestry
