> On July 19, 2017, 8:11 a.m., David Radley wrote: > > addons/models/0010-base_model.json > > Line 105 (original), 105 (patched) > > <https://reviews.apache.org/r/60938/diff/2/?file=1778152#file1778152line105> > > > > I am not sunderstanding why some of these endpoints have the > > islegacyattribute on one end and some have it on both. It seems to be > > somehting to do with whetehr the relationships is composition or > > aggregation ; in that case the container end has the legacy flag.
if a regular attribute is also defined as a relationship attribute then the attribute endpoint is tagged with legacy flag. for e.g. hive_table.columns and hive_column.table is defined as regular attribute using inverseRef/ownedRef constraint and as a relationship attribute in relationshipDef) - legacy flag on both ends In "hive_db_tables" relationshipDef, hive_table.db is a regular and relationship attribute (tagged as legacy) but hive_db.tables is only relationship attribute (not tagged as legacy). Hope this helps. > On July 19, 2017, 8:11 a.m., David Radley wrote: > > addons/models/0030-hive_model.json > > Line 554 (original), 554 (patched) > > <https://reviews.apache.org/r/60938/diff/2/?file=1778153#file1778153line554> > > > > why has this composition got the legacy flag on both ends ? Whereas > > otehr only have it one one . commented above > On July 19, 2017, 8:11 a.m., David Radley wrote: > > addons/models/0080-storm_model.json > > Line 150 (original), 150 (patched) > > <https://reviews.apache.org/r/60938/diff/2/?file=1778156#file1778156line150> > > > > shouldn't this be aggregation ? since a storm node can be shared acoss multiple storm topologies and not tied to a single topology made it as ASSOCIATION > On July 19, 2017, 8:11 a.m., David Radley wrote: > > addons/models/0080-storm_model.json > > Line 158 (original), 158 (patched) > > <https://reviews.apache.org/r/60938/diff/2/?file=1778156#file1778156line158> > > > > do we need the isLagacyAttribute here? not needed, since "topolgies" attribute is a new relationship attribute and not a regular attribute > On July 19, 2017, 8:11 a.m., David Radley wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > > Lines 256 (patched) > > <https://reviews.apache.org/r/60938/diff/2/?file=1778170#file1778170line257> > > > > Does the API still allow creation of entities with constaints - how > > will this come through to thie code. yes, to support backward compatibility entity creation with constraints is still allowed. - Sarath ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60938/#review180926 ----------------------------------------------------------- On July 17, 2017, 11:25 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60938/ > ----------------------------------------------------------- > > (Updated July 17, 2017, 11:25 p.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-1959 > https://issues.apache.org/jira/browse/ATLAS-1959 > > > Repository: atlas > > > Description > ------- > > * Improve relationship model to support create/update operations and the > following cardinalities (previously supported using inverseReference): > 1 to 1 > 1 to many > many to 1 > many to many > > > * Change legacyLabel flag in AtlasRelationshipEndDef to boolean flag. > * Add unit tests for the above cases. > > > Diffs > ----- > > addons/models/0010-base_model.json 303f3796 > addons/models/0030-hive_model.json a795f0f3 > addons/models/0050-falcon_model.json 7755fa86 > addons/models/0060-hbase_model.json 1d264df4 > addons/models/0080-storm_model.json 25360ff0 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java > 68da6af1 > intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java > 2de9bdf0 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipDef.java > fc820d49 > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipEndDef.java > f80ea895 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java e94dd190 > intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java > 841b66f7 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java f97d7674 > intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java > PRE-CREATION > intg/src/test/java/org/apache/atlas/TestUtilsV2.java 9774583d > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 6f6d74bc > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java > 12e8bb1f > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java > cd9a47ad > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > 3ff6fbef > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > d4fdc257 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 157f8cd2 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > f4257be7 > > repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java > de8e7ef3 > > repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java > d9017319 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreHardDeleteV1Test.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java > 67702231 > > > Diff: https://reviews.apache.org/r/60938/diff/3/ > > > Testing > ------- > > added unit test - AtlasRelationshipStoreV1Test > > mvn clean package - succeeded with no errors. > > > Thanks, > > Sarath Subramanian > >
