----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61046/#review181161 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On July 21, 2017, 9:45 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61046/ > ----------------------------------------------------------- > > (Updated July 21, 2017, 9:45 p.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Nixon Rodrigues. > > > Bugs: ATLAS-1960 > https://issues.apache.org/jira/browse/ATLAS-1960 > > > Repository: atlas > > > Description > ------- > > **Background** > Export & Import APIs did not generate correct error in HA-mode on a passive > node. > > **Root Cause** > The _ActiveServerFilter_ handles redirection based when HA-mode is active. > There is a special treatment given to _admin_ URIs, where _admin_ URIs are > allowed to execute even on PASSIVE node. > > **Solution** > Since Export, Import APIs are on _AdminResource_, the special treatmean to > _admin_ URIs has been extended to exclude execution of these API end points. > > **Additional Comment** > We may have to add few more method endpoints to this list, as those may > encounter similar issue. Potentially, _metrics_ & _activeSearches_ may have > this same problem. > > > Diffs > ----- > > webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java > 36f2688e > > webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java > a8d11103 > > > Diff: https://reviews.apache.org/r/61046/diff/1/ > > > Testing > ------- > > **Unit tests** > - Updated unit tests. > - Executed existing tests. > > **Function tests** > On local VM by changing application property and using debugger to step thru. > > > Thanks, > > Ashutosh Mestry > >
