----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61088/#review181332 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java Lines 74 (patched) <https://reviews.apache.org/r/61088/#comment256866> as per recent dev list discussions we should use relationships not relationship attributes here in the Text and in the constant name I do not think the inserts and the text make sense. From the code one is an entity type and one is an attribtue name. repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Lines 510 (patched) <https://reviews.apache.org/r/61088/#comment256872> Can we include more context to this error message. for example the search that was passed and which part was incorrect. repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Lines 517 (patched) <https://reviews.apache.org/r/61088/#comment256875> Are we checking that the relationship we find is valid for the entity ? repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Lines 519 (patched) <https://reviews.apache.org/r/61088/#comment256873> As above - it would be great to have more context in the error message repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Lines 528 (patched) <https://reviews.apache.org/r/61088/#comment256874> I would think in this case we would not sort at all. If we are coding a default - we should include the default annotation for the Swagger. repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Lines 563 (patched) <https://reviews.apache.org/r/61088/#comment256871> Can we include the Excpetion message in what does back to the user? should we log here? repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Lines 733 (patched) <https://reviews.apache.org/r/61088/#comment256870> How does this work for maps? webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java Lines 264 (patched) <https://reviews.apache.org/r/61088/#comment256869> As this will end up in the Swagger - please add more description including any defaults and errors that the user needs to be aware of. webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java Lines 273 (patched) <https://reviews.apache.org/r/61088/#comment256868> I suggest a sort direction would be useful here, maybe defined as an enum that include Ascending, descending and no sort. - David Radley On July 25, 2017, 7:38 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61088/ > ----------------------------------------------------------- > > (Updated July 25, 2017, 7:38 a.m.) > > > Review request for atlas, keval bhatt and Madhan Neethiraj. > > > Bugs: ATLAS-1988 > https://issues.apache.org/jira/browse/ATLAS-1988 > > > Repository: atlas > > > Description > ------- > > Add a new endpoint (v2/search/relationship) in DiscoveryREST to search for > related entities. > > Parameters: > [ guid, attributeName, sortBy, limit, offset ] > > Related entities search on hive_db: > http://localhost:21000/api/atlas/v2/search/relationship?guid=<db_guid>&attributeName=__hive_table.db&sortBy=name&limit=25&offset=0 > http://localhost:21000/api/atlas/v2/search/relationship?guid=<db_guid>&attributeName=__hive_table.db&sortBy=qualifiedName&limit=25&offset=0 > > Related entities search on hive_table: > http://localhost:21000/api/atlas/v2/search/relationship?guid=<table_guid>&attributeName=columns&sortBy=name&limit=25&offset=0 > http://localhost:21000/api/atlas/v2/search/relationship?guid=<table_guid>&attributeName=db&sortBy=name&limit=25&offset=0 > http://localhost:21000/api/atlas/v2/search/relationship?guid=<table_guid>&attributeName=sd&sortBy=qualifiedName&limit=25&offset=0 > > Related entities search on hive_column: > http://localhost:21000/api/atlas/v2/search/relationship?guid=<column_guid>&attributeName=table&sortBy=qualifiedName&limit=25&offset=0 > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java d723b2a9 > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java > 58274403 > > repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java > 764b548f > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > b183c72a > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > b8e0227c > > repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java > 1bf03464 > > repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java > 8481a4f6 > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java efab72a3 > > > Diff: https://reviews.apache.org/r/61088/diff/2/ > > > Testing > ------- > > mvn clean package suceeded. > > > Thanks, > > Sarath Subramanian > >
