----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61370/#review182015 -----------------------------------------------------------
Fix it, then Ship it! Looks ok overall. repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java Line 144 (original), 147 (patched) <https://reviews.apache.org/r/61370/#comment257825> init => initContext or initRequestContext for better understanding when being used explicitly within a test. Only init() can be confusing. repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateV1Test.java Line 107 (original), 110 (patched) <https://reviews.apache.org/r/61370/#comment257826> init => initContext or initRequestContext - Apoorv Naik On Aug. 2, 2017, 3:29 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61370/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2017, 3:29 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2014 > https://issues.apache.org/jira/browse/ATLAS-2014 > > > Repository: atlas > > > Description > ------- > > updated type create/update to populate createdBy and updatedBy fields > > > Diffs > ----- > > intg/src/test/java/org/apache/atlas/TestUtilsV2.java 14614f18 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java > 3638e198 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java > 6037d435 > > repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java > b835d223 > > repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java > 72107994 > > repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java > 82692cfb > > repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java > 485ec201 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java > 62ef21c9 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java > 2ac0fc66 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java > 263ad5be > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateV1Test.java > e2a80108 > > > Diff: https://reviews.apache.org/r/61370/diff/1/ > > > Testing > ------- > > Updated the unit tests and verified that fields createdBy and updatedBy are > populated correctly. > > > Thanks, > > Madhan Neethiraj > >
