----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61037/#review182444 -----------------------------------------------------------
Ship it! Ship It! - Sarath Subramanian On July 22, 2017, 1:55 p.m., David Radley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61037/ > ----------------------------------------------------------- > > (Updated July 22, 2017, 1:55 p.m.) > > > Review request for atlas, Madhan Neethiraj and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > ATLAS-1980: Add relationship instance validation to check end point type > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java > b24f99f6f9337aa10f40e9f10024fe5a345c3540 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > 49e08a070a803a36253b502666947ab92ffe39d3 > > > Diff: https://reviews.apache.org/r/61037/diff/1/ > > > Testing > ------- > > ran junits. > checked that I could still create a relationship > checked that the error message came out as expected when a existant guid > associated with the wrong type of entity was supplied. > > > Thanks, > > David Radley > >