----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61523/#review182487 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Aug. 9, 2017, 1:21 p.m., keval bhatt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61523/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2017, 1:21 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, > Nixon Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-2020 > https://issues.apache.org/jira/browse/ATLAS-2020 > > > Repository: atlas > > > Description > ------- > > 1. Searched hive_table in basic search. > 2. Checked "Include historical entities" check box - Result table had DELETED > entities. > 3. Added Columns filter "columns" - This fired a new query with > excludeDeletedEntities set to True and fetched only the ACTIVE entities and > reset (unchecked) "Include historical entities" . > > Expected that the current value of excludeDeletedEntities would be used when > Column filtering. > > After Column filtering , explicitly had to check "Include historical > entities" to list the DELETED entities. > > > Diffs > ----- > > dashboardv2/package.json e2e3d8c > dashboardv2/public/css/scss/loader.scss 7d461c8 > dashboardv2/public/css/scss/override.scss d2a4bec > dashboardv2/public/css/scss/panel.scss d1c2961 > dashboardv2/public/js/router/Router.js f858ee2 > dashboardv2/public/js/templates/common/TableLayout_tmpl.html e2b8a86 > dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html > 3177c7e > dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html > 91f1a67 > dashboardv2/public/js/utils/CommonViewFunction.js 4abec08 > dashboardv2/public/js/utils/TableLayout.js 3c9ff3b > dashboardv2/public/js/views/business_catalog/SideNavLayoutView.js da42554 > dashboardv2/public/js/views/common/aboutAtlas.js 9561b83 > dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 56379a4 > dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js e27edf4 > dashboardv2/public/js/views/schema/SchemaLayoutView.js 6f9b6e3 > dashboardv2/public/js/views/search/SearchDetailLayoutView.js b22fae8 > dashboardv2/public/js/views/search/SearchLayoutView.js 0c39b02 > dashboardv2/public/js/views/search/SearchResultLayoutView.js d1b1a02 > > > Diff: https://reviews.apache.org/r/61523/diff/2/ > > > Testing > ------- > > Done one round of sanity testing > > > Thanks, > > keval bhatt > >
