----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61552/#review182587 -----------------------------------------------------------
Looks good overall. Is this an IT or UT ? This should be under IT I believe, that would eliminate the need of starting the server. - Apoorv Naik On Aug. 10, 2017, 11:20 a.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61552/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2017, 11:20 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-2038 > https://issues.apache.org/jira/browse/ATLAS-2038 > > > Repository: atlas > > > Description > ------- > > This patch enable the Unittest from this testclass and includes unit test > cases for testing Authentication and Authorization Filters which can fail if > any regression is introduced in this Filters and authentication/authorization > process. ( eg bugs ATLAS-2009). > > > Diffs > ----- > > > webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterTest.java > 389eefe > webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java > ad87025 > > > Diff: https://reviews.apache.org/r/61552/diff/1/ > > > Testing > ------- > > Excecuted unit and Integration test from mvn clean install > > > Thanks, > > Nixon Rodrigues > >
