----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61085/#review183059 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java Lines 123 (patched) <https://reviews.apache.org/r/61085/#comment259050> consider moving this method to a utility class - GraphHelper, fetch all relationships given a vertex and relationship name. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java Lines 128 (patched) <https://reviews.apache.org/r/61085/#comment259052> consider refactoring this method with something like: public static boolean vertexHasRelationshipWithType(AtlasVertex vertex, String relationshipType) { Iterator<AtlasEdge> iter = GraphHelper.getAdjacentEdgesByLabel(vertex, AtlasEdgeDirection.BOTH, relationshipType); return (iter != null) ? iter.hasNext() : false; } - Sarath Subramanian On July 24, 2017, 10:18 a.m., David Radley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61085/ > ----------------------------------------------------------- > > (Updated July 24, 2017, 10:18 a.m.) > > > Review request for atlas, Madhan Neethiraj and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > ATLAS-1983: Add relationship cardinality validation > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java > b24f99f6f9337aa10f40e9f10024fe5a345c3540 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipDef.java > c17e875d10169753b76fcdb483e2ca85195104b2 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > 49e08a070a803a36253b502666947ab92ffe39d3 > > > Diff: https://reviews.apache.org/r/61085/diff/1/ > > > Testing > ------- > > ran Junits > Successfully added one relationship, then added a second which resulted in > the error. > > > Thanks, > > David Radley > >
