-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61667/
-----------------------------------------------------------
(Updated Aug. 16, 2017, 10:07 p.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath
Subramanian.
Changes
-------
Removed unncessary change
Bugs: ATLAS-2044
https://issues.apache.org/jira/browse/ATLAS-2044
Repository: atlas
Description
-------
In-memory filtering is needed to weed out any false positive results from index
query. False positive matches happen when the search string is present "as is"
after a special token which is used by the indexer (solr, elasticsearch) to
tokenize the string (during indexing as well as querying)
eg.
name = /a/b/c
search string "a", "b", "c" will match this name every time under equality,
startsWith, endsWith check as it's present immediately after the special token.
The patch adds extra level of filtering on the the result set obtained from the
index query.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
74197ca8
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
9cd83fb4
repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java
d556bf1a
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
b209ecb4
repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java
PRE-CREATION
Diff: https://reviews.apache.org/r/61667/diff/3/
Changes: https://reviews.apache.org/r/61667/diff/2-3/
Testing
-------
REST and UI testing no longer show the false positive matches.
mvn clean package -Pdist (in progress)
Thanks,
Apoorv Naik
