----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61788/#review183362 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasType.java Line 54 (original), 54 (patched) <https://reviews.apache.org/r/61788/#comment259392> I suggest adding some comments to these methods along the lines of the wording in the Jira. - David Radley On Aug. 21, 2017, 6:05 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61788/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2017, 6:05 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2074 > https://issues.apache.org/jira/browse/ATLAS-2074 > > > Repository: atlas > > > Description > ------- > > Currently AtlasType.resolveReferences() method is marked as public. > Implementations in sub-types likely to update the state of the type object; > hence this method is only called during initialization/updates to > type-registry. To prevent potential misuse of this method, which can result > in errors, resolveReference() method is made package-private. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java de3394f1 > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > 56c3ed38 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 9dad95df > intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java 1cd27b39 > intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 90c898a3 > intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java > 934dffce > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2 > intg/src/main/java/org/apache/atlas/type/AtlasType.java c99eb7f1 > > > Diff: https://reviews.apache.org/r/61788/diff/1/ > > > Testing > ------- > > Verified that Atlas builds successfully after this change in method accessor. > > > Thanks, > > Madhan Neethiraj > >
