----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61589/#review184016 -----------------------------------------------------------
Fix it, then Ship it! intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java Line 133 (original), 140 (patched) <https://reviews.apache.org/r/61589/#comment260031> When both ends have the same type and name, perhaps we should require second end to be not specified in relationship def? This can help avoid duplicate end-def. - Madhan Neethiraj On Aug. 28, 2017, 11:26 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61589/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2017, 11:26 p.m.) > > > Review request for atlas, David Radley and Madhan Neethiraj. > > > Bugs: ATLAS-2040 > https://issues.apache.org/jira/browse/ATLAS-2040 > > > Repository: atlas > > > Description > ------- > > Relationship with many-to-many cardinality gives incorrect relationship > attribute value when same attribute name and same type is specified at both > ends. > > For e.g. employee-friends type where same attribute 'friends' in type > 'Employee' is specified at both ends > > Add more unit tests to test these cases > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java > 3de02d08 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 6f30ff35 > intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 98be2b8d > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 0177f7e4 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > 42713763 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > fbb98584 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 4e7aa473 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreHardDeleteV1Test.java > 2c311403 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java > 33ef8c0f > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java > a35647dc > > > Diff: https://reviews.apache.org/r/61589/diff/4/ > > > Testing > ------- > > * added new UTs to test many-to-many relationships on same attribute > name/same type > * added new UTs to test one-to-one relationships on same attribute name/same > type > * mvn clean install -DskipITs=true suceeded without any failures > > > Thanks, > > Sarath Subramanian > >
