> On Aug. 28, 2017, 3:37 p.m., Ashutosh Mestry wrote: > > Question: _require.js_ does not have bust parameter. Is this intentional? > > If yes, what is the rationale? > > > > http://localhost:21000/js/libs/requirejs/require.js > > keval bhatt wrote: > Yes, it is intentional Because its library and we are not going to change > it.
Mostly yes, but if we do upgrade, we may have a serious problem. My thinking is that we should add this to libraries as well. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61940/#review183936 ----------------------------------------------------------- On Aug. 28, 2017, 1:22 p.m., keval bhatt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61940/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2017, 1:22 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, > Nixon Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-2090 > https://issues.apache.org/jira/browse/ATLAS-2090 > > > Repository: atlas > > > Description > ------- > > Grunt task is updated to handle Cache busting issue, so now after every > successful build grunt task will add new time as the query string for static > content i.e .CSS and .JS > > > Diffs > ----- > > dashboardv2/gruntfile.js 900ee40 > dashboardv2/package.json 6068c79 > dashboardv2/public/index.html f572049 > dashboardv2/public/index.html.tpl PRE-CREATION > dashboardv2/public/js/main.js 63e9abc > > > Diff: https://reviews.apache.org/r/61940/diff/1/ > > > Testing > ------- > > Build the atlas code and checked the query string for static content i.e.CSS > and .JS, its working as expected. > > > Thanks, > > keval bhatt > >
