----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61200/#review184401 -----------------------------------------------------------
Fix it, then Ship it! addons/hive-bridge/src/main/resources/atlas-hive-import-log4j.xml Lines 35 (patched) <https://reviews.apache.org/r/61200/#comment260593> maxFileSize is not supported by DailyRollingFileAppender. Adding this <param> results in the following WARN log at startup: log4j:WARN No such property [maxFileSize] in org.apache.log4j.DailyRollingFileAppender. Please revert this change; revert other similar changes as well. distro/src/conf/atlas-log4j.xml Line 38 (original), 39 (patched) <https://reviews.apache.org/r/61200/#comment260594> " Max" - typo? - Madhan Neethiraj On July 28, 2017, 2:55 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61200/ > ----------------------------------------------------------- > > (Updated July 28, 2017, 2:55 a.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-1996 > https://issues.apache.org/jira/browse/ATLAS-1996 > > > Repository: atlas > > > Description > ------- > > **Problem** > Existing log4J configuration did not include max size parameter. This caused > logs to grow making it hard for human log readers. > > Another contributing factor to log size growth is TitanDB's > _IndexSerializer_. When this is used, the query conversion from graph query > to indexed query is written as info log entry. > > With the recent changes, many more index queries are used, thus contributing > to growth of log files. > > **Solution** > > Added maxFileSize parameter. > Changed _com.thinkaurelius.titan_ log level to _warn_. > > **Additional Info** > Defaults need to be set in _Ambari_ so that they reflect correctly as part of > deployment. > > > Diffs > ----- > > addons/hive-bridge/src/main/resources/atlas-hive-import-log4j.xml c1184e5 > distro/src/conf/atlas-log4j.xml a0ef6a9 > typesystem/src/main/resources/atlas-log4j.xml c30403e > > > Diff: https://reviews.apache.org/r/61200/diff/1/ > > > Testing > ------- > > **Functional tests** > Observed configuration changes in the logs generated. > > > Thanks, > > Ashutosh Mestry > >
