----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62236/#review185257 -----------------------------------------------------------
Ship it! @Keval - the fix is good. The patch applies only in branch-0.8; but the review indicates its for master. Can you please check? If this fix is needed in master as well, can you please create another patch? Thanks! - Madhan Neethiraj On Sept. 12, 2017, 6:35 a.m., keval bhatt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62236/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2017, 6:35 a.m.) > > > Review request for atlas, Apoorv Naik, Ayub Pathan, Madhan Neethiraj, Nixon > Rodrigues, Sarath Subramanian, and Sharmadha Sainath. > > > Bugs: ATLAS-2128 > https://issues.apache.org/jira/browse/ATLAS-2128 > > > Repository: atlas > > > Description > ------- > > 1. Created 300 hive_tables. > 2. On Basic Search in UI , fired search typename= hive_table > 3. hive_table results were fetched across 12 pages - 25 entities in each page > - which is the correct behavior. > 4. On Advanced Search in UI , fired search typename = hive_table > a. In the 1st page , 1- 25 results were shown. > b. On clicking next , in the 2nd page , 26 - 50 results were shown > c. On clicking next , Expected to land in 3rd page with 51 - 75 results , > but , 26-50 results were loaded again and the Next Button was disabled. > > Calls made to the Atlas backend seem to be correct. On clicking "Next" each > time , correct set of results were fetched. For example , call was made to > fetch entities from offset 50 , limit = 25 , but the UI still showed 26-50 > results and disabled "Next" button. > > > Diffs > ----- > > dashboardv2/public/js/views/search/SearchResultLayoutView.js 970d6a3 > > > Diff: https://reviews.apache.org/r/62236/diff/1/ > > > Testing > ------- > > Tested with 200 data next and previous buttons is working as expected. > > > Thanks, > > keval bhatt > >
