----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62227/#review185270 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java Lines 121 (patched) <https://reviews.apache.org/r/62227/#comment261567> I would suggest to define an error code for this case, instead of using INTERNAL_ERROR. - Madhan Neethiraj On Sept. 11, 2017, 9:03 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62227/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2017, 9:03 p.m.) > > > Review request for atlas, Madhan Neethiraj and Sharmadha Sainath. > > > Bugs: ATLAS-2120 > https://issues.apache.org/jira/browse/ATLAS-2120 > > > Repository: atlas > > > Description > ------- > > This is a minor change, that performs additional check during import process. > > Import process now matches type definition for the types being imported. It > fails and logs exception if types do not match. > > > Diffs > ----- > > docs/src/site/twiki/Import-API-Options.twiki cc09fc7 > > repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java > 68bc583 > > repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java > 42f7011 > > repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java > d80fab0 > repository/src/test/resources/hdfs_path1.zip PRE-CREATION > repository/src/test/resources/tag1.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/62227/diff/1/ > > > Testing > ------- > > **Unit tests** > - Additional failure unit tests added. > > **Functional tests** > - Executed success and failure scenarios. > > > Thanks, > > Ashutosh Mestry > >
