----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62366/#review185525 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Sept. 16, 2017, 2:49 p.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62366/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2017, 2:49 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2140 > https://issues.apache.org/jira/browse/ATLAS-2140 > > > Repository: atlas > > > Description > ------- > > In various places in the codebase exceptions are declared unnecessarily > broadly or without actually throwing it. Which could cause confusion in the > caller, making it harder to handling it, and recovering from this. > > > Diffs > ----- > > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java > 349da66 > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java > 3b384f8 > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/publisher/FalconEventPublisher.java > ea81226 > > addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java > 5193832 > > addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java > d999a6a > > plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoader.java > d7ec65d > > plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderUtil.java > dfdad88 > > > Diff: https://reviews.apache.org/r/62366/diff/1/ > > > Testing > ------- > > > Thanks, > > Zsombor Gegesy > >