----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62390/#review185639 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Sept. 18, 2017, 7:45 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62390/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2017, 7:45 p.m.) > > > Review request for atlas, Apoorv Naik and Sarath Subramanian. > > > Bugs: ATLAS-2146 > https://issues.apache.org/jira/browse/ATLAS-2146 > > > Repository: atlas > > > Description > ------- > > Refactored to use _VisibleForTesting_ annotation instead of > _powermock.whitebox_. > > This is type safe. > > > Diffs > ----- > > repository/pom.xml e1e41d7 > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > ad21ee4 > > repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java > de48573 > > repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java > b3c790a > > repository/src/test/java/org/apache/atlas/discovery/EntityDiscoveryServiceTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java > 8eb7a51 > > repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java > cf17ef2 > > > Diff: https://reviews.apache.org/r/62390/diff/1/ > > > Testing > ------- > > **Unit tests** > - Executed impacted unit tests. > - Build with tests. > > > Thanks, > > Ashutosh Mestry > >
