----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62420/#review185761 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Sept. 19, 2017, 11:33 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62420/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2017, 11:33 p.m.) > > > Review request for atlas, keval bhatt and Madhan Neethiraj. > > > Bugs: ATLAS-2148 > https://issues.apache.org/jira/browse/ATLAS-2148 > > > Repository: atlas > > > Description > ------- > > **Implementation** > > - _DataAccess.save_ now returns entity with GUID set. Logic uses > _EntityMutationResponse_ for inferring the GUID. > - REST APIs have undergone minor changes. CURL calls updated (see below). > > > _Please used attached JSON for the examples below._ > > **Retrieve List of Saved Searches** > ```javascript > curl -g -X GET -u admin:admin -H "Content-Type: application/json" -H > "Cache-Control: no-cache" "http://localhost:21000/api/atlas/v2/search/saved"; > ``` > > **Retrieve Specific Saved Searches** > > ```javascript > curl -g -X GET -u admin:admin -H "Content-Type: application/json" -H > "Cache-Control: no-cache" > "http://localhost:21000/api/atlas/v2/search/saved/BASIC/my_search1"; > ``` > > ```javascript > curl -g -X GET -u admin:admin -H "Content-Type: application/json" -H > "Cache-Control: no-cache" > "http://localhost:21000/api/atlas/v2/search/saved/ADVANCED/my_search3"; > ``` > > **Save** > ```javascript > curl -g -X POST -u admin:admin -H "Content-Type: application/json" -H > "Cache-Control: no-cache" "http://localhost:21000/api/atlas/v2/search/saved"; > -d @../docs/savedSearch.json > ``` > > **Update** > ```javascript > curl -g -X PUT -u admin:admin -H "Content-Type: application/json" -H > "Cache-Control: no-cache" "http://localhost:21000/api/atlas/v2/search/saved"; > -d @../docs/savedSearch.json > ``` > > **Delete** > ```javascript > curl -g -X DELETE -u admin:admin -H "Content-Type: application/json" -H > "Cache-Control: no-cache" > "http://localhost:21000/api/atlas/v2/search/saved/0d0f75ef-b101-466f-843e-60196b81c98e"; > ``` > > > Diffs > ----- > > addons/models/0010-base_model.json 8f38f596 > intg/src/main/java/org/apache/atlas/model/profile/AtlasUserSavedSearch.java > b0698fcf > > repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java > baaee85d > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > ad21ee48 > > repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java > 26eee200 > repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java > bc93cc6e > > repository/src/main/java/org/apache/atlas/repository/userprofile/UserProfileService.java > 766d1c7d > > repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java > 4e832968 > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ad595c81 > > > Diff: https://reviews.apache.org/r/62420/diff/3/ > > > Testing > ------- > > **Unit tests** > Updated to reflect new logic. > > **Functional tests** > From the new UI. > CURL calls. > > > File Attachments > ---------------- > > saved Search > > https://reviews.apache.org/media/uploaded/files/2017/09/19/f9f6ec2d-28f6-487a-8126-aaf6fc8a1028__savedSearch.json > saved search for update > > https://reviews.apache.org/media/uploaded/files/2017/09/19/2b1d4619-65d8-4435-87cb-9b11878a7420__savedSearch-for-update.json > > > Thanks, > > Ashutosh Mestry > >
