-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62484/
-----------------------------------------------------------

(Updated Sept. 22, 2017, 9:53 p.m.)


Review request for atlas, keval bhatt and Madhan Neethiraj.


Changes
-------

Updates include:
- Removed search types from method signatures.


Bugs: ATLAS-2160
    https://issues.apache.org/jira/browse/ATLAS-2160


Repository: atlas


Description
-------

**Implementation**

There are 2 additional APIs:
* Saved Search using _type_ and _name_.
* Saved search using _guid_.

Once _AtlasUserSavedSearch_ is executed, execute _basic_ or _advanced_ search 
using the _searchType_. The results are returned in _AtlasSearchResult_ form.

**CURL**

Retrieve Saved Search:
```javascript
curl -g -X GET -u admin:admin -H "Content-Type: application/json" -H 
"Cache-Control: no-cache"  
"http://localhost:21000/api/atlas/v2/search/saved/Tax%20Tables";
```

Search results using saved search using search name and search type:
```javascript
curl -g -X GET -u admin:admin -H "Content-Type: application/json" -H 
"Cache-Control: no-cache"  
"http://localhost:21000/api/atlas/v2/search/saved/execute/Tax%20Tables";
```

Search results using saved search GUID:
```javascript
curl -g -X GET -u admin:admin -H "Content-Type: application/json" -H 
"Cache-Control: no-cache"  
"http://localhost:21000/api/atlas/v2/search/saved/execute/guid/18a21a1b-af61-47c6-a50a-34e8ae81dad3";
```


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/model/profile/AtlasUserSavedSearch.java 
8ecd52d9 
  
repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java 
630e776a 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
102c3292 
  
repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java
 aa8fc399 
  
repository/src/main/java/org/apache/atlas/repository/userprofile/UserProfileService.java
 99d13afb 
  
repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java
 713dade2 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java aed82ae0 


Diff: https://reviews.apache.org/r/62484/diff/4/

Changes: https://reviews.apache.org/r/62484/diff/3-4/


Testing
-------

**Unit tests**
Executed existing tests.

**Functional tests**
Executed APIs using CURL calls.


Thanks,

Ashutosh Mestry

Reply via email to