----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62747/#review186986 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Oct. 3, 2017, 11:03 a.m., keval bhatt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62747/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2017, 11:03 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, > Nixon Rodrigues, Sarath Subramanian, and Sharmadha Sainath. > > > Bugs: ATLAS-2163 > https://issues.apache.org/jira/browse/ATLAS-2163 > > > Repository: atlas > > > Description > ------- > > 1. Created a tag tag1. > 2. Fired basic search with classification name = tag1 and saved search as > "tag_basic_search" > 3. Fired DSL search with query = tag1 and saved search as "tag_DSL_search" > 4. Deleted the tag. > 5. Selected "tag_DSL_search" - this populated query text box with tag name . > Search threw invalid expression - which is expected. > 6. With Basic search ,on selecting "tag_basic_search" , no information is > populated in classification name. Classification name is null in the Basic > POST request body. > 7. Atlas displaying an error notification when selecting the saved search, > saying tag name invalid would be user friendly in case of deleted > tags/invalid tags . It is not very explicit to the user that the tag is > deleted. > > > Diffs > ----- > > dashboardv2/public/css/scss/theme.scss 7196702 > dashboardv2/public/js/router/Router.js 59d22c9 > dashboardv2/public/js/utils/Messages.js feccdc0 > dashboardv2/public/js/views/audit/AuditTableLayoutView.js e8483e4 > dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js ebc0021 > dashboardv2/public/js/views/search/SearchResultLayoutView.js e8151fd > dashboardv2/public/js/views/search/save/SaveSearchItemView.js 07d8df7 > > > Diff: https://reviews.apache.org/r/62747/diff/1/ > > > Testing > ------- > > If user search for tag/type in basic search using saved search but that > type/tag is deleted from backend then UI will show error message. "Invalid > Expression or Tag/Type has been deleted". > > > Thanks, > > keval bhatt > >
