----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62765/#review187083 -----------------------------------------------------------
Ship it! Ship It! - Ayub Pathan On Oct. 4, 2017, 10:51 a.m., keval bhatt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62765/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2017, 10:51 a.m.) > > > Review request for atlas, Apoorv Naik, Ayub Pathan, Ashutosh Mestry, Madhan > Neethiraj, and Nixon Rodrigues. > > > Bugs: ATLAS-2188 > https://issues.apache.org/jira/browse/ATLAS-2188 > > > Repository: atlas > > > Description > ------- > > For example, the below query has trailing space in the query resulting to not > returning anything, but if you see semantically this query seems to be > correct. > If a user by mistake enters a whitespace at the beginning or end of search > query, this will result in null response, which seems to be very strict. > Instead, UI can trim the whitespaces at the beginning or end of the query. > Please let me know your thoughts. > query json sample: > ``` > {"excludeDeletedEntities":true,"entityFilters":{"condition":"AND","criterion":[{"attributeName":"name","operator":"neq","attributeValue":"123"},{"attributeName":"name","operator":"startsWith","attributeValue":" > > hbase"},{"attributeName":"owner","operator":"startsWith","attributeValue":"hrt_qa"}]},"tagFilters":null,"attributes":[],"query":null,"limit":25,"offset":0,"typeName":"hbase_table","classification":null} > ``` > > > Diffs > ----- > > dashboardv2/public/js/utils/CommonViewFunction.js fc20b02 > dashboardv2/public/js/utils/Overrides.js bdc15db > dashboardv2/public/js/views/search/SearchResultLayoutView.js 0e9838f > > > Diff: https://reviews.apache.org/r/62765/diff/1/ > > > Testing > ------- > > Done one round of sanity testing for search result. > > > Thanks, > > keval bhatt > >
