----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62405/#review187582 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Sept. 21, 2017, 8:45 a.m., David Radley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62405/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2017, 8:45 a.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Repository: atlas > > > Description > ------- > > ATLAS2031 Allow AtlasClassificationDef entitytypes removal > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java > 603516d49f1e6ce2acd8cb1b45bd89d51cff7e94 > > > Diff: https://reviews.apache.org/r/62405/diff/2/ > > > Testing > ------- > > 1) create a classificationDef with 2 valid entityTypes EntityA and EntityB > 2) update classification def to remove EntityTypeB > 3) create an instance of EntityC , try to apply the classificaiton to it . It > should fail > 4) update the classification to have an empty list of classifications. > 5) Repeat step 3 and it should now work. > > > File Attachments > ---------------- > > ATLAS2031.patch > > https://reviews.apache.org/media/uploaded/files/2017/09/21/28a75f1f-3b35-4ffb-a915-010ebf265a6b__ATLAS2031.patch > > > Thanks, > > David Radley > >
