> On Oct. 11, 2017, 3:51 p.m., Apoorv Naik wrote: > > catalog/pom.xml > > Line 46 (original), 49 (patched) > > <https://reviews.apache.org/r/62889/diff/1/?file=1852376#file1852376line54> > > > > Any issues with Lucene 4.10.4 with TP2 ?
Hi Apoorv, For catalog I just preserved the dependency versions we were already using. Catalog is due for removal so I don't think there would be any point updating its dependencies. The 4.10.4 lucene version property was only if we are in the 'titan1' profile, but we know that catalog doesn't work with titan1 because catalog is code to TP2, so I stuck with the non-titan1-profile version, i.e 4.8.1. - Graham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62889/#review187662 ----------------------------------------------------------- On Oct. 11, 2017, 1:43 p.m., Graham Wallis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62889/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2017, 1:43 p.m.) > > > Review request for atlas. > > > Repository: atlas > > > Description > ------- > > This patch contains changes to 13 POM files to simplify the selection of > graph database, which should be > performed by specifying the GRAPH-PROVIDER system variable, e.g. > > mvn clean install -DGRAPH-PROVIDER=titan0 > > If GRAPH-PROVIDER is not specified, the default graph database is selected. > This is currently titan0 > If GRAPH-PROVIDER is specified, valid values are titan0 and titan1. > > The old graph profiles ('titan0', 'titan1') have been removed. > > This patch also simplifies dependency management in the POM files and removes > a number of duplicate entries. > > > Diffs > ----- > > catalog/pom.xml 0d13ae47bc1ce1890d706c6ee6c2d3ddeeb42d73 > distro/pom.xml 9bea00852cb10ddca363ef1e726487394f6947f3 > distro/src/conf/atlas-application.properties > 585a57919d8ce5f5a921918c27e45c0dbc660043 > graphdb/api/pom.xml 186e7455353c4d073f297868cc884c178d102106 > graphdb/graphdb-impls/pom.xml 62a09944f7655098319d477d362c7181f4b373d1 > graphdb/titan0/pom.xml df89e4fa52581f60e5ba962b114911a1b582f0b0 > graphdb/titan0/src/test/resources/atlas-application.properties > 3058330668424e0b860d0bfe932f78bfb3db8ec1 > graphdb/titan1/pom.xml 146155b73c24dbe10408a5d7071d6c9df02cf514 > graphdb/titan1/src/test/resources/atlas-application.properties > 99fe18a9d177403c8d7b41f2486709f1c6f24c3d > pom.xml 39ae6e7239b690cbf6dff69028b0d6e392777415 > repository/pom.xml b7eedde0a30a1716bc9665f2acfa02e169ba183f > typesystem/src/test/resources/atlas-application.properties > d7537a516551d745fa0ab5f854c9207cb7a2cfc1 > webapp/pom.xml bfa79e8101f1de962c26c48e3c71beb8e73b8876 > > > Diff: https://reviews.apache.org/r/62889/diff/1/ > > > Testing > ------- > > Builds before and after POM changes with no new test failures being > introduced. > > > Thanks, > > Graham Wallis > >
