----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63193/#review188878 -----------------------------------------------------------
server-api/src/main/java/org/apache/atlas/listener/ActiveStateChangeHandler.java Lines 29 (patched) <https://reviews.apache.org/r/63193/#comment265860> consider using enum for order information: public enum handlerOrder { HBASE_AUDIT_REPOSITORY(0), GRAPH_BACKED_SEARCH_INDEXER(1), TYPEDEF_STORE_INITIALIZER(2), DEFAULT_METADATA_SERVICE(3), NOTIFICATION_HOOK_CONSUMER(4); private final int order; handlerOrder(int order) { this.order = order; } public int getOrder() { return order; } } - Sarath Subramanian On Oct. 20, 2017, 4:20 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63193/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2017, 4:20 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2220 > https://issues.apache.org/jira/browse/ATLAS-2220 > > > Repository: atlas > > > Description > ------- > > Active state change listener order is made predictable > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java > 5a5a2c10 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > 9cd29916 > > repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java > d394810d > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > 99d21078 > > server-api/src/main/java/org/apache/atlas/listener/ActiveStateChangeHandler.java > 87a69ef5 > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > 6790512d > > webapp/src/main/java/org/apache/atlas/web/service/ActiveInstanceElectorService.java > 5071204a > > > Diff: https://reviews.apache.org/r/63193/diff/1/ > > > Testing > ------- > > Verified the order state-change listeners are set correctly during > initialization. > > > Thanks, > > Madhan Neethiraj > >
