----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63241/#review189172 -----------------------------------------------------------
dashboardv2/public/js/utils/Overrides.js Lines 101 (patched) <https://reviews.apache.org/r/63241/#comment266124> Its better to have validation on keypress event instead of keyup event because allowing user to add more then 1 e and then showing input box in red color that wont look good dashboardv2/public/js/views/tag/addTagModalView.js Lines 316 (patched) <https://reviews.apache.org/r/63241/#comment266125> its better to have variable name as inputClassName. In the else condition of ternary, you can pass "number-input-negative" and then pass to input box class name that will remove one if condition of input box creation. - keval bhatt On Oct. 24, 2017, 9:52 a.m., pratik pandey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63241/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2017, 9:52 a.m.) > > > Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and > Sharmadha Sainath. > > > Bugs: ATLAS-2219 > https://issues.apache.org/jira/browse/ATLAS-2219 > > > Repository: atlas > > > Description > ------- > > For tag attributes of data type double , float etc, the corresponding text > box is not accepting 'E' character for providing exponential values. > > > Diffs > ----- > > dashboardv2/public/css/scss/form.scss 694e885 > dashboardv2/public/js/utils/Enums.js 78445e1 > dashboardv2/public/js/utils/Overrides.js dd36859 > dashboardv2/public/js/views/tag/addTagModalView.js a169867 > > > Diff: https://reviews.apache.org/r/63241/diff/1/ > > > Testing > ------- > > Unit testing is done. > Tested by adding value for attributes for float,double type with > 0123,123.009,123E9,123e9,12.23e9,12.23E9 > -0123,-123.009,-123E9,-123e9,-12.23e9,-12.23E9 > > > Thanks, > > pratik pandey > >
