> On Oct. 30, 2017, 4:29 p.m., Sarath Subramanian wrote: > > repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java > > Line 242 (original), 242 (patched) > > <https://reviews.apache.org/r/63417/diff/1/?file=1872700#file1872700line242> > > > > how did this work for tinkerpop2 with range(0,0)?
Tinkerpop2's range() step was inclusive, so a range(0,0) passes the first traverser. However, in Tinkerpop3 the lower bound of the range() step is exclusive, so range(0,0) will pass nothing, whereas range(0,1) will pass one traverser. - Graham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63417/#review189609 ----------------------------------------------------------- On Oct. 30, 2017, 4:25 p.m., Graham Wallis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63417/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2017, 4:25 p.m.) > > > Review request for atlas. > > > Repository: atlas > > > Description > ------- > > ATLAS-2242.patch > This patch contains fixes for a couple of tests in > GraphBackedDiscoveryServiceTest. > Although in Atlas master a user will no longer be able to issue gremlin > queries directly, the unit tests of the graph should still be correct. > This patch rectifies the gremlin3 traversals to return the correct types for > vertex and edge queries. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java > a43e0236c67fa04c210ef4c302a9a2851cb0b250 > > repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java > 11980bec24a109cce7ee7b8c5d4a9f3d39ae124a > > > Diff: https://reviews.apache.org/r/63417/diff/1/ > > > Testing > ------- > > Built and tested with janus provider > > > Thanks, > > Graham Wallis > >
