[
https://issues.apache.org/jira/browse/ATLAS-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225451#comment-16225451
]
Sarath Subramanian commented on ATLAS-2243:
-------------------------------------------
Code Review: https://reviews.apache.org/r/63421
> Code improvement suggested by Static code analysis
> --------------------------------------------------
>
> Key: ATLAS-2243
> URL: https://issues.apache.org/jira/browse/ATLAS-2243
> Project: Atlas
> Issue Type: Bug
> Components: atlas-core
> Affects Versions: 1.0.0
> Reporter: Sarath Subramanian
> Assignee: Sarath Subramanian
> Fix For: 1.0.0
>
> Attachments: ATLAS-2243.1.patch
>
>
> ** CID 168691: Control flow issues (DEADCODE)
>
> /repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java:
> 782 in
> org.apache.atlas.repository.store.graph.v1.EntityGraphRetriever.mapSystemAttributes(org.apache.atlas.repository.graphdb.AtlasEdge,
> org.apache.atlas.model.instance.AtlasRelationship)()
>
>
>
> ________________________________________________________________________________________________________
> *** CID 168691: Control flow issues (DEADCODE)
>
> /repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java:
> 782 in
> org.apache.atlas.repository.store.graph.v1.EntityGraphRetriever.mapSystemAttributes(org.apache.atlas.repository.graphdb.AtlasEdge,
> org.apache.atlas.model.instance.AtlasRelationship)()
> 776 relationship.setCreateTime(new
> Date(GraphHelper.getCreatedTime(edge)));
> 777 relationship.setUpdateTime(new
> Date(GraphHelper.getModifiedTime(edge)));
> 778
> 779 Integer version = GraphHelper.getVersion(edge).intValue();
> 780
> 781 if (version == null) {
> >>> CID 168691: Control flow issues (DEADCODE)
> >>> Execution cannot reach this statement: "version =
> java.lang.Integer...".
> 782 version = Integer.valueOf(1);
> 783 }
> 784
> 785 relationship.setVersion(version.longValue());
> 786 relationship.setStatus(GraphHelper.getEdgeStatus(edge));
> 787
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
