----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63460/#review189795 -----------------------------------------------------------
Ship it! Ship It! - Nixon Rodrigues On Nov. 1, 2017, 11:03 a.m., pratik pandey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63460/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2017, 11:03 a.m.) > > > Review request for atlas, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, > Nixon Rodrigues, and Sharmadha Sainath. > > > Bugs: ATLAS:2222 > https://issues.apache.org/jira/browse/ATLAS:2222 > > > Repository: atlas > > > Description > ------- > > In UI , When string attribute filter contains comma , it is taken as separate > attribute filter. > For example basic search : hive_table , filter : description = a , b > POST request body : > ```json > { > "excludeDeletedEntities":true, > "entityFilters":{ > "condition":"AND", > "criterion":[ > { > "attributeName":"description", > "operator":"eq", > "attributeValue":"a" > }, > { > "attributeName":"b", > "operator":"string" > } > ] > }, > "tagFilters":null, > "attributes":[ > > ], > "limit":25, > "offset":0, > "typeName":"hive_table", > "classification":null > } > ``` > > The search throws 400 Bad request with error notification "Attribute b not > found for type hive_table". > > This is seen only in UI ,as when search is fired with attributeValue given as > "a,b" using REST API , fetches correct results. > ```json > { > "excludeDeletedEntities":true, > "entityFilters":{ > "condition":"AND", > "criterion":[ > { > "attributeName":"description", > "operator":"eq", > "attributeValue":"a,b" > } > ] > }, > "tagFilters":null, > "attributes":[ > > ], > "limit":25, > "offset":0, > "typeName":"hdfs_path", > "classification":null > } > ``` > > > Diffs > ----- > > dashboardv2/public/js/utils/CommonViewFunction.js 37f14d5 > > > Diff: https://reviews.apache.org/r/63460/diff/1/ > > > Testing > ------- > > Done one round of sanity testing. > > > Thanks, > > pratik pandey > >
