----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63658/#review190761 -----------------------------------------------------------
Fix it, then Ship it! intg/src/main/java/org/apache/atlas/type/AtlasType.java Lines 160 (patched) <https://reviews.apache.org/r/63658/#comment268372> consider removing this line or LOG the error repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java Lines 109 (patched) <https://reviews.apache.org/r/63658/#comment268390> if this is specific to "hive_table" type change method name to something like "getHiveTableSchema" repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java Lines 125 (patched) <https://reviews.apache.org/r/63658/#comment268391> same as above change method name to "getHiveColumnSchema" repository/src/main/java/org/apache/atlas/query/Expressions.java Lines 32 (patched) <https://reviews.apache.org/r/63658/#comment268392> unimplemented methods? repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java Line 50 (original), 49 (patched) <https://reviews.apache.org/r/63658/#comment268393> typesystem reference? repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java Line 27 (original), 27 (patched) <https://reviews.apache.org/r/63658/#comment268394> for migration cases, existing vertices might still have __type => typeSystem webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java Line 193 (original), 180 (patched) <https://reviews.apache.org/r/63658/#comment268395> remove commented lines. - Sarath Subramanian On Nov. 9, 2017, 10:27 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63658/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2017, 10:27 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2251 > https://issues.apache.org/jira/browse/ATLAS-2251 > > > Repository: atlas > > > Description > ------- > > Here is summary of the changes in this patch: > - removed TypeSystem implementation from Atlas > - references to TypeSystem have either been removed or replaced to use > AtlasTypeRegistry > - notification module has been refactored to move notification message > classes to intg module > - updated serialize/deserialize of notifications to use Jackson library > instead of GSON. Wire format of the message remain same as the one from GSON > generated JSON > - V1 data classes used in REST API & notifications have been over to model > package in intg module, along with other classes used in V2 REST APIs > - updated all Hook implementations, UTs and ITs for the changes in classes > used in notifications > - removed all Scala sources from Atlas > > Verified that functions correctly with this patch, except for the TODO items > listed below: > - DSL implementation in Scala, which used TypeSystem, has been removed. This > needs to be replaced with equivalent implementation to use AtlasTypeRegistry > - Few REST APIs that use V1 classes (like MetadataRepository) have been > stubbed out - DataSetLineageResource, LineageResource, > MetadataDiscoveryResource. These need to be updated to use V2 implementations > > > Diffs > ----- > > addons/falcon-bridge/pom.xml a732e5dc > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java > ff745596 > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java > 188b7543 > > addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java > 72129217 > addons/hbase-bridge/pom.xml ebdb3613 > > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java > 8c7481af > > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseOperationContext.java > ce0f2129 > > addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java > 032cb518 > addons/hdfs-model/pom.xml 4fd738ad > addons/hive-bridge/pom.xml faf14d35 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java > 663fcdcd > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > d2d2fb54 > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > 0e8284d2 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java > 0d163ee9 > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java > 0256cf37 > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetastoreBridgeIT.java > d09db1b4 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > f7404ae1 > addons/sqoop-bridge/pom.xml d46d8a99 > > addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java > 50e20fa0 > addons/storm-bridge/pom.xml 16104ca7 > > addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java > c3df8fcd > > addons/storm-bridge/src/test/java/org/apache/atlas/storm/hook/StormAtlasHookIT.java > e0800b80 > authorization/pom.xml 143c4e4c > client/client-v1/pom.xml 2b492bb8 > client/client-v1/src/main/java/org/apache/atlas/AtlasClient.java 8bbc89b6 > client/client-v1/src/main/java/org/apache/atlas/EntityAuditEvent.java > 904674d9 > client/client-v1/src/main/java/org/apache/atlas/SerDe.java cdc35094 > client/client-v1/src/test/java/org/apache/atlas/AtlasClientTest.java > c387be14 > client/pom.xml b69c0773 > common/pom.xml c2e5da65 > common/src/main/java/org/apache/atlas/AtlasConfiguration.java > common/src/main/java/org/apache/atlas/repository/Constants.java 5475514c > graphdb/api/pom.xml c949a98e > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java > dded76f8 > graphdb/common/pom.xml d290b92b > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java > bc63a697 > > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java > 2408287b > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java > ffb6b37f > intg/pom.xml 2f801e76 > > intg/src/main/java/org/apache/atlas/model/notification/EntityNotification.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/model/notification/HookNotification.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/type/AtlasType.java dc0d300c > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java bd4b0e90 > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 5f3cefdd > > intg/src/main/java/org/apache/atlas/v1/model/instance/AtlasSystemAttributes.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/v1/model/instance/Id.java PRE-CREATION > intg/src/main/java/org/apache/atlas/v1/model/instance/Referenceable.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/v1/model/instance/Struct.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/v1/model/lineage/DataSetLineageResponse.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/v1/model/lineage/LineageResponse.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/v1/model/lineage/SchemaResponse.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/v1/model/notification/EntityNotificationV1.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/v1/model/notification/HookNotificationV1.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/v1/model/typedef/AttributeDefinition.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/v1/model/typedef/ClassTypeDefinition.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/v1/model/typedef/EnumTypeDefinition.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/v1/model/typedef/HierarchicalTypeDefinition.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/v1/model/typedef/Multiplicity.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/v1/model/typedef/StructTypeDefinition.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/v1/model/typedef/TraitTypeDefinition.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/v1/model/typedef/TypesDef.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/v1/typesystem/types/utils/TypesUtil.java > PRE-CREATION > intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java d0effd67 > intg/src/test/java/org/apache/atlas/TestUtilsV2.java 91fdb473 > intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java > 8f3ac5b0 > notification/pom.xml 9b369403 > notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 38f32082 > notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java > e3bb71ca > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java > 6bb8d73a > > notification/src/main/java/org/apache/atlas/notification/AbstractMessageDeserializer.java > 37a57d17 > > notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java > 4f56bd8d > > notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java > 8cf1e8e5 > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationBaseMessage.java > 3b377de6 > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessage.java > 63d93c97 > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessageDeserializer.java > 2a175baf > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationStringMessage.java > 41485a05 > > notification/src/main/java/org/apache/atlas/notification/MessageVersion.java > 7f966388 > > notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java > 8809225d > > notification/src/main/java/org/apache/atlas/notification/SplitMessageAggregator.java > 148b57fe > > notification/src/main/java/org/apache/atlas/notification/entity/EntityMessageDeserializer.java > a6f7e646 > > notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java > 379e8155 > > notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java > 6a9b362d > > notification/src/main/java/org/apache/atlas/notification/hook/HookMessageDeserializer.java > 8337de04 > > notification/src/main/java/org/apache/atlas/notification/hook/HookNotification.java > a25aa521 > notification/src/test/java/org/apache/atlas/hook/AtlasHookTest.java > d59cb1cf > notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java > 08a20bd4 > > notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationMockTest.java > 09e2e437 > > notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java > a1e13b91 > > notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java > f313ddc4 > > notification/src/test/java/org/apache/atlas/notification/AbstractNotificationTest.java > 655252cb > > notification/src/test/java/org/apache/atlas/notification/AtlasNotificationMessageTest.java > 27b5034e > > notification/src/test/java/org/apache/atlas/notification/MessageVersionTest.java > d1af4b0b > > notification/src/test/java/org/apache/atlas/notification/SplitMessageAggregatorTest.java > 0807221b > > notification/src/test/java/org/apache/atlas/notification/entity/EntityMessageDeserializerTest.java > 7b513dae > > notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationDeserializerTest.java > PRE-CREATION > > notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java > c3a2db8f > > notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationTest.java > PRE-CREATION > > notification/src/test/java/org/apache/atlas/notification/hook/HookMessageDeserializerTest.java > 49b877bc > > notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java > dd3257e0 > pom.xml 3c48b867 > repository/pom.xml f981c76f > > repository/src/main/java/org/apache/atlas/discovery/AtlasLineageService.java > 5f49625b > > repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java > af7f1b4d > repository/src/main/java/org/apache/atlas/discovery/DiscoveryService.java > e86047eb > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > 7f24d5ae > > repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java > 3ae41c8d > repository/src/main/java/org/apache/atlas/discovery/SearchIndexer.java > 8e67e326 > > repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java > 9b0aa4c0 > > repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java > aed8659c > > repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java > 27de0edd > > repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java > b9366956 > > repository/src/main/java/org/apache/atlas/gremlin/GremlinExpressionFactory.java > d603150f > > repository/src/main/java/org/apache/atlas/gremlin/optimizer/AliasFinder.java > 3e6c39ab > > repository/src/main/java/org/apache/atlas/gremlin/optimizer/CallHierarchyVisitor.java > 60893537 > > repository/src/main/java/org/apache/atlas/gremlin/optimizer/ExpandAndsOptimization.java > d8ecd076 > > repository/src/main/java/org/apache/atlas/gremlin/optimizer/ExpandOrsOptimization.java > a48a007f > > repository/src/main/java/org/apache/atlas/gremlin/optimizer/ExpressionFinder.java > 27210498 > > repository/src/main/java/org/apache/atlas/gremlin/optimizer/FunctionGenerator.java > 1a93d0fc > > repository/src/main/java/org/apache/atlas/gremlin/optimizer/GremlinOptimization.java > bfa45af8 > > repository/src/main/java/org/apache/atlas/gremlin/optimizer/GremlinQueryOptimizer.java > a0c08fdc > > repository/src/main/java/org/apache/atlas/gremlin/optimizer/HasForbiddenType.java > 3fb9faa7 > repository/src/main/java/org/apache/atlas/gremlin/optimizer/IsOr.java > ab740873 > repository/src/main/java/org/apache/atlas/gremlin/optimizer/IsOrParent.java > 72085d03 > > repository/src/main/java/org/apache/atlas/gremlin/optimizer/OptimizationContext.java > 86c8b987 > > repository/src/main/java/org/apache/atlas/gremlin/optimizer/OrderFinder.java > 792fc52e > > repository/src/main/java/org/apache/atlas/gremlin/optimizer/PathExpressionFinder.java > 0e9070df > > repository/src/main/java/org/apache/atlas/gremlin/optimizer/RangeFinder.java > fa8ca858 > > repository/src/main/java/org/apache/atlas/gremlin/optimizer/RepeatExpressionFinder.java > 8344f365 > > repository/src/main/java/org/apache/atlas/gremlin/optimizer/SplitPointFinder.java > f0295e7d > > repository/src/main/java/org/apache/atlas/gremlin/optimizer/UpdatedExpressions.java > 06351ea4 > repository/src/main/java/org/apache/atlas/query/Expressions.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/query/QueryParser.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/repository/DiscoverInstances.java > 6261499e > repository/src/main/java/org/apache/atlas/repository/IRepository.java > 1637e117 > > repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java > b72ee7dc > > repository/src/main/java/org/apache/atlas/repository/RepositoryConfiguration.java > 261a6d03 > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java > 2a1881b0 > > repository/src/main/java/org/apache/atlas/repository/converters/AtlasClassificationFormatConverter.java > cd4f165e > > repository/src/main/java/org/apache/atlas/repository/converters/AtlasEntityFormatConverter.java > 1ce6168b > > repository/src/main/java/org/apache/atlas/repository/converters/AtlasEnumFormatConverter.java > 734bd0ca > > repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java > 9bde5db6 > > repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java > f946b9ca > > repository/src/main/java/org/apache/atlas/repository/converters/AtlasStructFormatConverter.java > 6b6ee015 > > repository/src/main/java/org/apache/atlas/repository/converters/TypeConverterUtil.java > 7902100e > > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java > f0fef1f0 > > repository/src/main/java/org/apache/atlas/repository/graph/EntityProcessor.java > 892b36d9 > > repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java > 2e8ae0c6 > > repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java > 76acf8ce > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java > 74886b56 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > 6eee24b1 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > ffe859b3 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphSchemaInitializer.java > e8776806 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java > d7a8fa91 > > repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java > e00ef96d > > repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java > b37fe758 > > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java > 1fb4ee99 > > repository/src/main/java/org/apache/atlas/repository/graph/VertexLookupContext.java > dd90be6f > > repository/src/main/java/org/apache/atlas/repository/memory/AttributeStores.java > 1fb9d693 > repository/src/main/java/org/apache/atlas/repository/memory/ClassStore.java > a74c79e4 > > repository/src/main/java/org/apache/atlas/repository/memory/HierarchicalTypeStore.java > 429730c9 > > repository/src/main/java/org/apache/atlas/repository/memory/IAttributeStore.java > b8cbe050 > > repository/src/main/java/org/apache/atlas/repository/memory/MemRepository.java > aef06a4d > > repository/src/main/java/org/apache/atlas/repository/memory/ReplaceIdWithInstance.java > 6741eb8d > > repository/src/main/java/org/apache/atlas/repository/memory/StructStore.java > 69a18a5b > repository/src/main/java/org/apache/atlas/repository/memory/TraitStore.java > 0cbb32d8 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > 5a0b74e3 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java > 7b349c46 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > a5db81bf > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java > 1eb41832 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > 86f1b884 > > repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java > 2dd339c2 > > repository/src/main/java/org/apache/atlas/repository/typestore/ITypeStore.java > 84779f40 > > repository/src/main/java/org/apache/atlas/repository/typestore/StorageException.java > c4f64f82 > > repository/src/main/java/org/apache/atlas/repository/typestore/StoreBackedTypeCache.java > f472fa61 > > repository/src/main/java/org/apache/atlas/repository/typestore/TypePersistenceVisitor.java > bfb1bfc7 > > repository/src/main/java/org/apache/atlas/repository/typestore/TypeVertexFinder.java > 8b381524 > > repository/src/main/java/org/apache/atlas/repository/typestore/TypeVertexInfo.java > 32a9a196 > > repository/src/main/java/org/apache/atlas/repository/typestore/TypeVisitor.java > a6e353c1 > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > 9eb695c0 > > repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java > 65b99cd0 > > repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java > 0370c8e3 > repository/src/main/java/org/apache/atlas/util/AttributeValueMap.java > 6e226049 > repository/src/main/java/org/apache/atlas/util/CompiledQueryCacheKey.java > 56a5a2a5 > repository/src/main/java/org/apache/atlas/util/IndexedInstance.java > 60ec8cc2 > repository/src/main/java/org/apache/atlas/util/NoopGremlinQuery.java > 280570e5 > repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 733aefde > repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala > 1190114c > repository/src/main/scala/org/apache/atlas/query/Expressions.scala bf9efd2e > > repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala > c2b3436a > repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala > 5f8ef8ae > repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala > 37015d8e > repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 4bc6e742 > repository/src/main/scala/org/apache/atlas/query/QueryProcessor.scala > e1e8408b > repository/src/main/scala/org/apache/atlas/query/Resolver.scala 1b42f3ee > repository/src/main/scala/org/apache/atlas/query/TypeUtils.scala 8d2c7aea > repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 7c6b60b7 > repository/src/test/java/org/apache/atlas/RepositoryServiceLoadingTest.java > 506d11c8 > repository/src/test/java/org/apache/atlas/TestModules.java 144f6182 > repository/src/test/java/org/apache/atlas/TestUtils.java 56bfb824 > > repository/src/test/java/org/apache/atlas/discovery/DataSetLineageServiceTest.java > 3db58fe3 > > repository/src/test/java/org/apache/atlas/discovery/EntityDiscoveryServiceTest.java > ced0aa04 > > repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java > bd730e43 > > repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java > 202f20c0 > repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java > 57bc74fb > repository/src/test/java/org/apache/atlas/repository/BaseTest.java 7e1df676 > > repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java > 551e6abb > > repository/src/test/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepositoryHATest.java > f66ac746 > > repository/src/test/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepositoryTest.java > a9dfee33 > > repository/src/test/java/org/apache/atlas/repository/audit/HBaseTestUtils.java > 984acfec > > repository/src/test/java/org/apache/atlas/repository/graph/AbstractGremlinQueryOptimizerTest.java > 88de2c49 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java > 0834601f > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java > 952a6448 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java > 9c0ef430 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java > 8c86235e > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexerMockTest.java > a98ef381 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexerTest.java > feffabf6 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperMockTest.java > a0894cd8 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java > e64c2c80 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java > 1f077ba0 > > repository/src/test/java/org/apache/atlas/repository/graph/Gremlin2QueryOptimizerTest.java > 8f638a08 > > repository/src/test/java/org/apache/atlas/repository/graph/Gremlin3QueryOptimizerTest.java > 47dff147 > > repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateHardDeleteTest.java > a3207fb8 > > repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java > ce43bdca > > repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java > 8518f931 > > repository/src/test/java/org/apache/atlas/repository/graph/TestIntSequence.java > b8eefca1 > > repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java > 7901ef68 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java > 718538a0 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1Test.java > 95b57618 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java > ef8bd2f2 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java > 8c58a928 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1Test.java > 407ebffb > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateV1Test.java > 6475639f > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java > 3f1ed031 > > repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java > 6e3dabb2 > > repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheTest.java > 2ea63ff0 > > repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java > e885b8c9 > > repository/src/test/java/org/apache/atlas/service/StoreBackedTypeCacheMetadataServiceTest.java > 5c37b9e2 > > repository/src/test/java/org/apache/atlas/util/CompiledQueryCacheKeyTest.java > 725aa43a > repository/src/test/java/org/apache/atlas/utils/HiveModel.java 4fc04737 > repository/src/test/scala/org/apache/atlas/query/ExpressionTest.scala > 918f3275 > repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala a948d16d > repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala > 880a0c61 > repository/src/test/scala/org/apache/atlas/query/HiveTitanSample.scala > fa0d3419 > repository/src/test/scala/org/apache/atlas/query/LexerTest.scala 10237a9e > repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala > b01cbf89 > repository/src/test/scala/org/apache/atlas/query/ParserTest.scala de5d8792 > repository/src/test/scala/org/apache/atlas/query/QueryTestsUtils.scala > f26f98e8 > server-api/pom.xml 6e99ca35 > server-api/src/main/java/org/apache/atlas/RequestContext.java 3e729b52 > server-api/src/main/java/org/apache/atlas/RequestContextV1.java 08aa9606 > server-api/src/main/java/org/apache/atlas/discovery/LineageService.java > 5aab3550 > > server-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java > e05a7755 > server-api/src/main/java/org/apache/atlas/listener/TypesChangeListener.java > 5ff6d4aa > server-api/src/main/java/org/apache/atlas/services/MetadataService.java > d2aa457b > > server-api/src/main/java/org/apache/atlas/typesystem/exception/EntityExistsException.java > b16cfa99 > > server-api/src/main/java/org/apache/atlas/typesystem/exception/NullRequiredAttributeException.java > db4b054c > typesystem/.gitignore c7029f81 > typesystem/LICENSE.md 5c304d1a > typesystem/doc/IDataType.uml 68051c3d > typesystem/doc/Instance.uml e11c6858 > typesystem/doc/QueryDSL.org 22b73862 > typesystem/doc/notes.MD 977d46c3 > typesystem/pom.xml 78cacb78 > > typesystem/src/main/java/org/apache/atlas/classification/InterfaceAudience.java > > typesystem/src/main/java/org/apache/atlas/typesystem/IInstance.java > adb28d48 > > typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java > 04af67cc > typesystem/src/main/java/org/apache/atlas/typesystem/IStruct.java e0f85761 > typesystem/src/main/java/org/apache/atlas/typesystem/ITypedInstance.java > c3bb9afc > > typesystem/src/main/java/org/apache/atlas/typesystem/ITypedReferenceableInstance.java > 6dae95c5 > typesystem/src/main/java/org/apache/atlas/typesystem/ITypedStruct.java > ced255c2 > typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java > 8cad2f8c > typesystem/src/main/java/org/apache/atlas/typesystem/Struct.java f8d2e42f > > typesystem/src/main/java/org/apache/atlas/typesystem/exception/TypeExistsException.java > 8a28e389 > > typesystem/src/main/java/org/apache/atlas/typesystem/exception/TypeNotFoundException.java > 3654a4ba > > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java > 3c08a026 > > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/DownCastStructInstance.java > e4ebb178 > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java > ba05a45f > > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/MapIds.java > e62f29da > > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java > be2634d6 > > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java > 766d2d0c > > typesystem/src/main/java/org/apache/atlas/typesystem/types/AbstractDataType.java > 874138b6 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java > 5561f0b2 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java > c24a55f1 > typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java > 2f2b0906 > typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java > f9f4abe6 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/DownCastFieldMapping.java > 85e288ed > typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumType.java > 82e22cee > > typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java > 40cb132c > typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumValue.java > d75259bb > > typesystem/src/main/java/org/apache/atlas/typesystem/types/FieldMapping.java > a2b3db29 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java > ac7f442e > > typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java > ab63fea3 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDependencySorter.java > aaec05c8 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/IConstructableType.java > d54da0af > typesystem/src/main/java/org/apache/atlas/typesystem/types/IDataType.java > a7a21238 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java > c213d75d > > typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphTraversal.java > 9a1847c6 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphWalker.java > 036d18dc > typesystem/src/main/java/org/apache/atlas/typesystem/types/StructType.java > 57f25177 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java > 4f8695be > typesystem/src/main/java/org/apache/atlas/typesystem/types/TraitType.java > bbb845aa > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java > 262f784f > > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUpdateException.java > 33d1cb5f > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java > 6a14dc41 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java > 9afa8730 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/ValueConversionException.java > f7561356 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCache.java > 0d864742 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/TypeCache.java > c8f65bec > > typesystem/src/main/java/org/apache/atlas/typesystem/types/package-info.java > fbd42169 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java > 39244dc7 > typesystem/src/main/resources/atlas-log4j.xml 510e2cfe > typesystem/src/main/scala/org/apache/atlas/typesystem/TypesDef.scala > b51048df > > typesystem/src/main/scala/org/apache/atlas/typesystem/builders/InstanceBuilder.scala > 9e22f674 > > typesystem/src/main/scala/org/apache/atlas/typesystem/builders/TypesBuilder.scala > 5ea345fe > > typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala > d4bed75e > > typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala > ca4dd7fe > > typesystem/src/main/scala/org/apache/atlas/typesystem/json/TypesSerialization.scala > 4478a44b > typesystem/src/test/java/org/apache/atlas/ApplicationPropertiesTest.java > 25a19cf1 > > typesystem/src/test/java/org/apache/atlas/typesystem/json/SerializationJavaTest.java > 5ee019cb > typesystem/src/test/java/org/apache/atlas/typesystem/types/BaseTest.java > 95c99e4f > typesystem/src/test/java/org/apache/atlas/typesystem/types/ClassTest.java > daecdd78 > typesystem/src/test/java/org/apache/atlas/typesystem/types/EnumTest.java > 23071922 > > typesystem/src/test/java/org/apache/atlas/typesystem/types/FieldMappingTest.java > 0259ade9 > > typesystem/src/test/java/org/apache/atlas/typesystem/types/HierarchicalTypeDependencySorterTest.java > 19bdccfc > > typesystem/src/test/java/org/apache/atlas/typesystem/types/HierarchicalTypeTest.java > 9f63f523 > typesystem/src/test/java/org/apache/atlas/typesystem/types/StructTest.java > 3a1675e1 > typesystem/src/test/java/org/apache/atlas/typesystem/types/TraitTest.java > 7c392138 > > typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeInheritanceTest.java > c13ef3a1 > > typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java > 0ef5d10d > > typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeUpdateBaseTest.java > 4a6ed2d0 > > typesystem/src/test/java/org/apache/atlas/typesystem/types/ValidationTest.java > 1a86cf32 > > typesystem/src/test/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheTest.java > 5c397dd8 > typesystem/src/test/resources/atlas-application.properties > typesystem/src/test/resources/policy-store.txt > typesystem/src/test/resources/sampleInstance.json > typesystem/src/test/resources/sampleTypes.json > typesystem/src/test/resources/users-credentials.properties > > typesystem/src/test/scala/org/apache/atlas/typesystem/builders/BuilderTest.scala > 9d1d00f1 > > typesystem/src/test/scala/org/apache/atlas/typesystem/builders/InstanceBuilderTest.scala > 0331c9cb > > typesystem/src/test/scala/org/apache/atlas/typesystem/builders/MultiplicityTest.scala > 91e72c7d > > typesystem/src/test/scala/org/apache/atlas/typesystem/builders/TypesBuilderTest.scala > d01adb4e > > typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala > 9e656a5d > > typesystem/src/test/scala/org/apache/atlas/typesystem/json/SerializationTest.scala > 931773dd > > typesystem/src/test/scala/org/apache/atlas/typesystem/json/TypesSerializationTest.scala > cfd4bdb2 > webapp/pom.xml 782c280c > webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 91ba1113 > webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java a95fac37 > > webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java > 53acf563 > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > 4646bff9 > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > e8020dbb > webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 191388a9 > > webapp/src/main/java/org/apache/atlas/web/resources/DataSetLineageResource.java > 435659e9 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 8b565071 > webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java > cba8ccfe > > webapp/src/main/java/org/apache/atlas/web/resources/MetadataDiscoveryResource.java > d7c66d33 > webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java > a9c55090 > webapp/src/main/java/org/apache/atlas/web/service/ActiveInstanceState.java > c6b4a6f7 > webapp/src/main/java/org/apache/atlas/web/util/LineageUtils.java ad2a697a > webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java 592c2a62 > > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java > 7e943300 > > webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java > a9889155 > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java > d41db3ee > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java > eb37fa82 > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java > e2d1022e > webapp/src/test/java/org/apache/atlas/util/RestUtilsTest.java 87259df2 > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java > e7538817 > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java > b90ea645 > > webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterTest.java > 5628b177 > webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java > 512750fc > webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java > 5806a10d > > webapp/src/test/java/org/apache/atlas/web/integration/DataSetLineageJerseyResourceIT.java > 9a0d0dcf > > webapp/src/test/java/org/apache/atlas/web/integration/EntityDiscoveryJerseyResourceIT.java > 157bf979 > > webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java > cf44d4af > > webapp/src/test/java/org/apache/atlas/web/integration/EntityLineageJerseyResourceIT.java > 38113908 > > webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java > d61a9afc > > webapp/src/test/java/org/apache/atlas/web/integration/MetadataDiscoveryJerseyResourceIT.java > a13f0696 > > webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java > c46689c0 > > webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java > 351e5ae7 > > webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java > 7ad2f767 > > > Diff: https://reviews.apache.org/r/63658/diff/3/ > > > Testing > ------- > > - verified that hook notifications from earlier version of hooks are > sucessfully processed by Atlas server > - verified that entitiy notificaitons generated by the server are > successfully processed by earlier version of Ranger > - succesfullt imported types, classifications and entities > - verified that basic-search works > > > Thanks, > > Madhan Neethiraj > >
