----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63792/#review191002 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/converters/AtlasEntityFormatConverter.java Line 129 (original), 129 (patched) <https://reviews.apache.org/r/63792/#comment268591> It will be safer to handle 'entity.getStatus() == null' here. - Madhan Neethiraj On Nov. 14, 2017, 9:32 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63792/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2017, 9:32 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2258 > https://issues.apache.org/jira/browse/ATLAS-2258 > > > Repository: atlas > > > Description > ------- > > * Disable DSL search related tests until v2 implementation is ready > > * Fix the following new IT failures: > EntityDiscoveryJerseyResourceIT.setUp:52->createTypes:203->BaseResourceIT.createType:206 > » AtlasService > EntityJerseyResourceIT.setUp:72->BaseResourceIT.createTypeDefinitionsV1:353->BaseResourceIT.createType:206 > » AtlasService > EntityLineageJerseyResourceIT.setUp:56->DataSetLineageJerseyResourceIT.setUp:60->BaseResourceIT.createTypeDefinitionsV1:353->BaseResourceIT.createType:206 > » AtlasService > MetadataDiscoveryJerseyResourceIT.setUp:57->createTypes:231->BaseResourceIT.createTypeDefinitionsV1:353->BaseResourceIT.createType:206 > » AtlasService > TypedefsJerseyResourceIT.testCreate:84->BaseResourceIT.createType:163->BaseResourceIT.batchCreateTypes:158 > » AtlasService > TypedefsJerseyResourceIT.testDuplicateCreate:112 » AtlasService Metadata > servi... > TypedefsJerseyResourceIT.testInvalidGets:200 Should've returned a 404 > expected [404] but found [503] > TypedefsJerseyResourceIT.testListTypesByFilter:277 » AtlasService Metadata > ser... > TypedefsJerseyResourceIT.testUpdate:133 » AtlasService Metadata service API > or... > > > Diffs > ----- > > client/client-v1/src/main/java/org/apache/atlas/EntityAuditEvent.java > 567205fb > intg/src/main/java/org/apache/atlas/type/AtlasType.java ce0a4755 > intg/src/main/java/org/apache/atlas/v1/model/instance/Referenceable.java > f1d28d1a > intg/src/main/java/org/apache/atlas/v1/model/instance/Struct.java 5aebd4b2 > > intg/src/main/java/org/apache/atlas/v1/model/notification/EntityNotificationV1.java > 549dbe36 > > intg/src/main/java/org/apache/atlas/v1/model/notification/HookNotificationV1.java > c70e7d0c > > repository/src/main/java/org/apache/atlas/repository/converters/AtlasEntityFormatConverter.java > 2229ecec > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > 89bf7dcd > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 11879e65 > > webapp/src/test/java/org/apache/atlas/web/integration/DataSetLineageJerseyResourceIT.java > 7e504800 > > webapp/src/test/java/org/apache/atlas/web/integration/EntityDiscoveryJerseyResourceIT.java > 75d3872c > > webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java > 0f585f9a > > webapp/src/test/java/org/apache/atlas/web/integration/MetadataDiscoveryJerseyResourceIT.java > f25fc5f8 > > webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java > cd876f4f > > > Diff: https://reviews.apache.org/r/63792/diff/1/ > > > Testing > ------- > > mvn clean package Validated the failing ITs succeeds > > > Thanks, > > Sarath Subramanian > >
