-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63954/#review191521
-----------------------------------------------------------


Ship it!




David - the fixes look good. However, it is critical to understand the details 
of the errors caused by misspelled attribute-names and presence of unknown 
attributes. Can you please update the JIRA with such details?

- Madhan Neethiraj


On Nov. 20, 2017, 5:30 p.m., David Radley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63954/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2017, 5:30 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS2269 Errors in the Area 0 and 3 models shown up by the latest Jackson 
> libraries
> 
> 
> Diffs
> -----
> 
>   addons/models/0000-Area0/0090-CloudPlatformsAndServices.json 803c0d1e 
>   addons/models/0300-Area3-SubjectArea/0320-CategoryHierarchy.json 804be9e1 
>   addons/models/0300-Area3-SubjectArea/0330-Terms.json c267fb23 
>   addons/models/0300-Area3-SubjectArea/0350-RelatedTerms.json 37e11417 
>   addons/models/0300-Area3-SubjectArea/0370-SemanticAssignment.json c5fd7cc9 
> 
> 
> Diff: https://reviews.apache.org/r/63954/diff/1/
> 
> 
> Testing
> -------
> 
> Built Atlas successfully with skipTests. here are test failures running unit 
> test.  
> I am unable to start Atlas at this time. 
> 
> I think that we need to make these corrections in the model - so that OMAS 
> and OMRS work that depends on these models can proceed.
> 
> 
> Thanks,
> 
> David Radley
> 
>

Reply via email to