----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64235/#review192427 -----------------------------------------------------------
Ship it! Ship It! - Sarath Subramanian On Nov. 30, 2017, 4:57 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64235/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2017, 4:57 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2289 > https://issues.apache.org/jira/browse/ATLAS-2289 > > > Repository: atlas > > > Description > ------- > > - refactored KafkaNotification to isolate the code that deals with embedded > Kafka start/stop to EmbeddedKafkaServer > - added info level logs on critical initialization paths > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/service/Services.java 6f880e4d > notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java > PRE-CREATION > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java > 152144b3 > > notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java > 8bc7cb4b > > > Diff: https://reviews.apache.org/r/64235/diff/1/ > > > Testing > ------- > > Verified that Atlas starts up and functions correctly with embedded Kafka. > > > Thanks, > > Madhan Neethiraj > >
