----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64350/#review192940 -----------------------------------------------------------
Ship it! Ship It! - Sarath Subramanian On Dec. 5, 2017, 11:27 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64350/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2017, 11:27 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2296 > https://issues.apache.org/jira/browse/ATLAS-2296 > > > Repository: atlas > > > Description > ------- > > Added following attributes to control whether to incldue sub-types in the > search results or not: > - SearchParameters.includeSubTypes > - SearchParameters.includeSubClassifications > > If no value is provided, the current behavior (of including sub-types in the > results) will be retained. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java > 557256e8 > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > 8413ce69 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 4aeaf47c > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 15659778 > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > 1119463e > > > Diff: https://reviews.apache.org/r/64350/diff/1/ > > > Testing > ------- > > Verified with curl calls that basic-search API : > - excludes sub-types/sub-classifications when the new fields are set to > 'false' > - includes sub-types/sub-classifications when the new fields are set to 'true' > - includes sub-types/sub-classifications when the new fields are not set > > > Thanks, > > Madhan Neethiraj > >
