----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64390/#review193040 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Dec. 6, 2017, 8:03 p.m., keval bhatt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64390/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2017, 8:03 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Nixon Rodrigues. > > > Bugs: ATLAS-2295 > https://issues.apache.org/jira/browse/ATLAS-2295 > > > Repository: atlas > > > Description > ------- > > Atlas UI for classification (index.html#!/tag/tagAttribute) currently lists > super-types of the classification - if the classification has any super-type. > It will be useful to list sub-types as well. > > In addition, listing of classifications in a hierarchical layout, instead of > current flat listing, would make it a lot more usable. Changes introduced in > ATLAS-2283 would provide necessary details for above UI updates. > > Also, ATLAS-2020 added "entityTypes" fields to classification, to specify > entity-types for which this classification can be applied to. It will be > useful to include this detail as well in classification details page. > Attach one or more files to this issue > > > Diffs > ----- > > dashboardv2/public/css/scss/override.scss 3d6f554 > dashboardv2/public/css/scss/tag.scss 8b5e6e2 > dashboardv2/public/css/scss/theme.scss 4ce51b2 > dashboardv2/public/js/main.js 7422684 > dashboardv2/public/js/router/Router.js e9c9e5e > dashboardv2/public/js/templates/common/AboutAtlas_tmpl.html a3cf90a > dashboardv2/public/js/templates/common/TableLayout_tmpl.html 0ec8301 > dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html > a08d9ab > dashboardv2/public/js/templates/entity/CreateEntityLayoutView_tmpl.html > 55f70a1 > dashboardv2/public/js/templates/profile/ProfileColumnLayoutView_tmpl.html > 5903afb > dashboardv2/public/js/templates/profile/ProfileTableLayoutView_tmpl.html > d0ae3e0 > dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html > 87a89b3 > dashboardv2/public/js/templates/search/save/SaveSearchItemView_tmpl.html > 9c47c24 > dashboardv2/public/js/templates/tag/CreateTagLayoutView_tmpl.html d9c5907 > dashboardv2/public/js/templates/tag/TagAttributeDetailLayoutView_tmpl.html > 715a04c > dashboardv2/public/js/templates/tag/TagAttributeItemView_tmpl.html 68f6423 > dashboardv2/public/js/templates/tag/TagLayoutView_tmpl.html 16e41a2 > dashboardv2/public/js/utils/Utils.js 84851b0 > dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js bae862c > dashboardv2/public/js/views/entity/CreateEntityLayoutView.js 36fe827 > dashboardv2/public/js/views/schema/SchemaLayoutView.js c199243 > dashboardv2/public/js/views/search/SearchDetailLayoutView.js cfb2aa4 > dashboardv2/public/js/views/search/SearchLayoutView.js 434e850 > dashboardv2/public/js/views/search/SearchResultLayoutView.js 7fd1d48 > dashboardv2/public/js/views/site/SideNavLayoutView.js 04ab118 > dashboardv2/public/js/views/tag/AddTagAttributeView.js 9b5e950 > dashboardv2/public/js/views/tag/AddTagModalView.js 52dd623 > dashboardv2/public/js/views/tag/CreateTagLayoutView.js 617df59 > dashboardv2/public/js/views/tag/TagAttributeDetailLayoutView.js 35d8cd3 > dashboardv2/public/js/views/tag/TagAttributeItemView.js edfda12 > dashboardv2/public/js/views/tag/TagDetailLayoutView.js 7b71388 > dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 2ea8734 > dashboardv2/public/js/views/tag/TagLayoutView.js df896da > > > Diff: https://reviews.apache.org/r/64390/diff/1/ > > > Testing > ------- > > Done one round of sanity testing > > > Thanks, > > keval bhatt > >
