----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64435/#review193231 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java Line 165 (original), 165 (patched) <https://reviews.apache.org/r/64435/#comment271791> Is this actually necessary? i.e. rather than clearing the attributes, generating the audit and then reinstating the attributes - could we not take a shallow copy of the entity to give to the audit? - Graham Wallis On Dec. 8, 2017, 3:20 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64435/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2017, 3:20 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2301 > https://issues.apache.org/jira/browse/ATLAS-2301 > > > Repository: atlas > > > Description > ------- > > While purging entity attributes for audit record creation, the removal from > map was done while in the middle of iterating the map. This caused the > 'concurrent modification' error. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/v1/model/instance/Struct.java 9f0be5fd > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java > 47d4e1df > > webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java > 4633de95 > > > Diff: https://reviews.apache.org/r/64435/diff/1/ > > > Testing > ------- > > Verified that audit record creation handles attribute purging correctly. > > > Thanks, > > Madhan Neethiraj > >
