> On Dec. 14, 2017, 4:31 p.m., David Radley wrote:
> > pom.xml
> > Lines 1796 (patched)
> > <https://reviews.apache.org/r/63462/diff/5/?file=1915262#file1915262line1796>
> >
> >     I can't see the syntax (b151) anywhere. 
> >     Oracle 
> > (http://www.oracle.com/technetwork/java/javase/8u151-relnotes-3850493.html)seems
> >  to define this release as : 
> >     "
> >     Java™ SE Development Kit 8, Update 151 (JDK 8u151)
> >     
> >     October 17, 2017
> >     
> >     The full version string for this update release is 1.8.0_151-b12 (where 
> > "b" means "build"). The version number is 8u151.
> >     "
> >     
> >     It seems to me that 151 is not a build. So we should not use b151.

Different JDKs may have the exact version string differ - the maven enforcer 
plugin documents how it strips the numbers out to form a normalised string that 
it uses.

The 'b151' was my 'shorthand' to approximate this, as I'd seen it used in other 
places, but I understand why perhaps it may be confusing & agree that 
technically it's not the build as such, it is indeed the update level. That 
being said I think most would understand - and more than likely look at the 
exact rule in the pom in any case. 

I could change to 'update 151'


> On Dec. 14, 2017, 4:31 p.m., David Radley wrote:
> > pom.xml
> > Lines 1801 (patched)
> > <https://reviews.apache.org/r/63462/diff/5/?file=1915262#file1915262line1801>
> >
> >     A nice to have - I wonder if there is a way to provide the level we 
> > found as an the insert

Not that I can see for these inbuilt rules. There is support for building 
custom rules, and there I could likely do exactly this. However that's more 
work, more code to support, and I don't think justifies the effort.

We have seen issues with bad maven levels, java levels not so sure, so I think 
this patch gives us value we need to get into the build??


- Nigel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63462/#review193808
-----------------------------------------------------------


On Dec. 13, 2017, 2:11 p.m., Nigel Jones wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63462/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2017, 2:11 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, David Radley, Graham Wallis, Madhan 
> Neethiraj, and Mandy Chessell.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-2245: Update maven dependency to 3.5.0
> Also updated Java Dependency to 8
> Both are enforced in the top level POM using the maven enforcer plugin
> Initial implementation used the 'dependencies' tag in the pom. However this 
> is deprecated, not inherited, and was primarily intended for plugins rather 
> than projects. 
> 
> THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7.
> Many users will need to update maven in particular
> 
> 
> Diffs
> -----
> 
>   graphdb/janus/pom.xml 5fe38184 
>   pom.xml 3b9a464b 
> 
> 
> Diff: https://reviews.apache.org/r/63462/diff/5/
> 
> 
> Testing
> -------
> 
> Test with mvn clean install
> 
> If Maven version is not 3.5.0:
> [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ 
> apache-atlas ---
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion 
> failed with message:
> ** Please upgrade maven to 3.5.2 or above. See 
> https://maven.apache.org/install.html
> 
> Similar for Java
> 
> If dependencies met, build continues ok
> 
> Proposed (in Jira) to update wiki page & send out email on dist list due to 
> developer impact
> THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7.
> Many users will need to update maven in particular
> 
> -- Update with 13 Dec patch --
> * Tested with mvn clean install
> * Checked JDK 1.8/151 or 152 works, that < 151 fails, and that Java 9 
> produces a warning
> * Checked maven 3.5.0 or above works, earlier fails
> 
> Also checked build environment - from build logs build server is using maven 
> 3.5.2 & java 1.8.0_152
> 
> **** --> 
> REVIEW QUESTION - I went with 3.5.0 (as Apache ranger hit bugs with 3.5.2.. 
> though that was only with enuciate), and java 1.8.0_151 (as I know many have 
> that, and it's easy to select when downloading). OK???
> **** --<
> 
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=1024m; 
> support was removed in 8.0
> Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 
> 2017-10-18T07:58:13Z)
> Maven home: /home/jenkins/tools/maven/latest
> Java version: 1.8.0_152, vendor: Oracle Corporation
> Java home: /usr/local/asfpackages/java/jdk1.8.0_152/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.4.0-43-generic", arch: "amd64", family: "unix"
> + java -version
> java version "1.8.0_152"
> Java(TM) SE Runtime Environment (build 1.8.0_152-b16)
> Java HotSpot(TM) 64-Bit Server VM (build 25.152-b16, mixed mode)
> 
> Example of failure errors:
> 
> [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ 
> apache-atlas ---
> [WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequireJavaVersion failed 
> with message:
> ** JAVA VERSION ERROR ** Java 8 (b151) or above is required.
> 
> 
> or
> 
> [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ 
> apache-atlas ---
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion 
> failed with message:
> ** MAVEN VERSION ERROR ** Maven 3.5.0 or above is required. See 
> https://maven.apache.org/install.html
> [WARNING] Rule 2: org.apache.maven.plugins.enforcer.RequireJavaVersion warned 
> with message:
> ** JAVA VERSION WARNING ** Java 9 and above has not been tested with Atlas.
> 
> 
> Thanks,
> 
> Nigel Jones
> 
>

Reply via email to