----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64533/#review194036 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Dec. 15, 2017, 4:15 p.m., David Radley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64533/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2017, 4:15 p.m.) > > > Review request for atlas, Madhan Neethiraj and Mandy Chessell. > > > Bugs: 2309 > https://issues.apache.org/jira/browse/2309 > > > Repository: atlas > > > Description > ------- > > ATLAS2309 Add Area 1 open metadata models > > I also added code to the relationshipdef so that it would not null pointer if > the relationship category was not specified. Instead it defaults to > association. > > > Diffs > ----- > > addons/models/0100-Area1-Collaboration/0110-Actors.json PRE-CREATION > addons/models/0100-Area1-Collaboration/0120-Collections.json PRE-CREATION > addons/models/0100-Area1-Collaboration/0130-Projects.json PRE-CREATION > addons/models/0100-Area1-Collaboration/0140-Communities.json PRE-CREATION > addons/models/0100-Area1-Collaboration/0150-Feedback.json PRE-CREATION > addons/models/0100-Area1-Collaboration/0160-Notes.json PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java > 4c69d6e8 > > > Diff: https://reviews.apache.org/r/64533/diff/1/ > > > Testing > ------- > > Brought up atlas and started it, then queries some of the types that are > added in the Area 1 models. > > Unit tests fail on my machine - this does not appear to be due to this patch. > > > Thanks, > > David Radley > >
