> On Dec. 15, 2017, 3:28 p.m., David Radley wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > > Lines 1029 (patched) > > <https://reviews.apache.org/r/63879/diff/3-4/?file=1897765#file1897765line1049> > > > > If we have a relationship guid - we trace it. I was expecting it to be > > involved with the matching of new and existing edges. > > Graham Wallis wrote: > I added the trace to find out whether we were ever getting a relationship > guid - but never saw one. > I left the trace in for good measure, but decided not to add a > relationshipGuid comparison.
As discussed, we suspect that the tests you are using are all legary entities. The suspision is that using non-legacy relationshipDefs to define the relationship will result in 'proper' v2 relationships. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63879/#review193913 ----------------------------------------------------------- On Dec. 18, 2017, 11:52 a.m., Graham Wallis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63879/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2017, 11:52 a.m.) > > > Review request for atlas. > > > Repository: atlas > > > Description > ------- > > ATLAS-2262.patch > This patch contains fixes for the EntityGraphMapper and related classes, to > fix intermittent relationship failures. > This change means that an UPDATE operation will inspect the existing and new > relationships and compare them fully before adding/modifying edges. Matching > elements will be reused, new elements will be added, and redundant elements > will be discarded. The behaviour should be consistent regardless of which > graph provider is being used. > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 3e602431400677cbe0d8fe440732b02bb4a30a62 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java > d6effbf77b7dbd3479bab3899730bdcbabdce351 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > b0f9845d6e92a6ef4bb53cccec537a0a54afb5e8 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AttributeMutationContext.java > b6d82dd834b8cc8b3bac630c084b91ac34dd0cec > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > f6a15b695e676bc035ce8336bcce7bacf1852ff9 > > repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java > ab25faaa9caffe5bf2796194057f0556d4bfc431 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java > 1f8b9fdbfd5d987288983f7be99ea0f36f7255d4 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java > b418fef90a0bcadba47679028c134b836bdd9079 > > > Diff: https://reviews.apache.org/r/63879/diff/5/ > > > Testing > ------- > > Build with test enabled, using Janus graph provider > > > Thanks, > > Graham Wallis > >
