----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64784/#review194362 -----------------------------------------------------------
Ship it! Ship It! - Sarath Subramanian On Dec. 21, 2017, 10:50 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64784/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2017, 10:50 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2320 > https://issues.apache.org/jira/browse/ATLAS-2320 > > > Repository: atlas > > > Description > ------- > > Full-text search processor didn't handle the case of wildcard classification > filter correctly, resulting in incorrect index query. Updated full-text > search processor (and entity search processor) to handle wildcard > classification filter correctly. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 7b75321b > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > 0a811f43 > > repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java > 95372d38 > repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java > 540cdba7 > > > Diff: https://reviews.apache.org/r/64784/diff/1/ > > > Testing > ------- > > - verified that basic-search with { "classification": "*", > "query":"query-string" } returns successfully with tagged entities that have > the given query string in entity-text > - verified that basic-search with { "classification": "*", > "type":"hive_column" } returns successfully with tagged hive_column entities > > > Thanks, > > Madhan Neethiraj > >
