-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64800/
-----------------------------------------------------------

(Updated Dec. 23, 2017, 12:57 a.m.)


Review request for atlas and Madhan Neethiraj.


Changes
-------

Resolved compilation errors due to previous bad rebase


Bugs: ATLAS-2229
    https://issues.apache.org/jira/browse/ATLAS-2229


Repository: atlas


Description
-------

Gremlin related changes
--------------------------------------------------------------------
Global aggregator instead of local, no implicit limits on aggregator
Error handling for malformed queries
Simplified outgoing traversal
Fix for groupBy followed by orderBy
Handled quoted string labels when using aggregator functions
--------------------------------------------------------------------

Removed space/comma separated query from DSL grammar


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fb741f8f 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
ece1516a 
  repository/src/main/java/org/apache/atlas/query/AtlasDSL.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/DSLVisitor.java b597a0da 
  repository/src/main/java/org/apache/atlas/query/Expressions.java 77350f09 
  repository/src/main/java/org/apache/atlas/query/GremlinTranslator.java 
6ce90e62 
  repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java 
0c7e2ed8 
  repository/src/main/java/org/apache/atlas/query/Lookup.java a64b6887 
  repository/src/main/java/org/apache/atlas/query/QueryParser.java 6e378a1f 
  repository/src/main/java/org/apache/atlas/query/QueryProcessor.java 5e07a922 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 
576e1298 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens 
8c147b4f 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 
058a5c80 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.tokens 
8c147b4f 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasAbstractDefStoreV1.java
 02dad468 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java
 d3253000 
  repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java 
b8731419 


Diff: https://reviews.apache.org/r/64800/diff/3/

Changes: https://reviews.apache.org/r/64800/diff/2-3/


Testing
-------

Testing done via UI

UTs and ITs have not been tackled yet, once all the existing cases are 
implemented that's the next big thing.


Thanks,

Apoorv Naik

Reply via email to