----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64859/#review194616 -----------------------------------------------------------
Fix it, then Ship it! addons/models/0000-Area0/0010-base_model.json Lines 193 (patched) <https://reviews.apache.org/r/64859/#comment273483> isOptional should be 'true' for 'uiParameters'. intg/src/main/java/org/apache/atlas/model/profile/AtlasUserSavedSearch.java Lines 132 (patched) <https://reviews.apache.org/r/64859/#comment273484> Consider replacing lines #132 - #134 with: sb.append(", uiParameters=").append(uiParameters); repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java Lines 60 (patched) <https://reviews.apache.org/r/64859/#comment273485> Consider replacing lines #60 - #64 with: savedSearch.setUiParameters((String) entity.getAttribute(PROPERTY_UI_PARAMETERS)); repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java Lines 86 (patched) <https://reviews.apache.org/r/64859/#comment273486> There is no need for 'null' check here. Consider replacing lines #86 - #89 with: entity.setAttribute(PROPERTY_UI_PARAMETERS, obj.getUiParameters()); - Madhan Neethiraj On Dec. 28, 2017, 9:11 a.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64859/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2017, 9:11 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan > Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-2272 > https://issues.apache.org/jira/browse/ATLAS-2272 > > > Repository: atlas > > > Description > ------- > > This patch includes changes to save the ui column paramter when particular > search is saved, so that this parameter can be used while rendering of > columns. > > JSON Structure > > { > "name": "test", > "guid": "3ab087c1-5597-4d57-9f49-46c38eaa4b90", > "searchParameters": { > "limit": null, > "typeName": "Asset", > "classification": null, > "query": "test111111", > "offset": null, > "excludeDeletedEntities": true, > "includeSubTypes": true, > "includeSubClassifications": true, > "entityFilters": null, > "attributes": null > }, > "searchType": "BASIC", > "uiParameters": > "Select::0,Type::1,Tags::2,Db::3,Description::4,Sd::5,CreateTime::6,Owner::7,Name::8" > } > > > Diffs > ----- > > addons/models/0000-Area0/0010-base_model.json 8d4234f6 > intg/src/main/java/org/apache/atlas/model/profile/AtlasUserSavedSearch.java > bd221219 > > repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java > 27575ce3 > > > Diff: https://reviews.apache.org/r/64859/diff/2/ > > > Testing > ------- > > Tested the CRUD operation of SavedSearch feature. > > > Thanks, > > Nixon Rodrigues > >
