----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64959/#review194797 -----------------------------------------------------------
Fix it, then Ship it! webapp/src/main/java/org/apache/atlas/web/resources/MetadataDiscoveryResource.java Line 159 (original), 149 (patched) <https://reviews.apache.org/r/64959/#comment273848> do we need explicit null handling here? AtlasType.toJson() returns null for null parameter webapp/src/main/java/org/apache/atlas/web/resources/MetadataDiscoveryResource.java Line 232 (original), 222 (patched) <https://reviews.apache.org/r/64959/#comment273849> same here - Sarath Subramanian On Jan. 4, 2018, 1:29 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64959/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2018, 1:29 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2321 > https://issues.apache.org/jira/browse/ATLAS-2321 > > > Repository: atlas > > > Description > ------- > > - updated V1 REST API for search to correctly handle empty results > - fixed incorrect results in V1 REST API for full-text-search > - removed unused members/imports > > > Diffs > ----- > > > webapp/src/main/java/org/apache/atlas/web/resources/MetadataDiscoveryResource.java > d8f3df32 > > > Diff: https://reviews.apache.org/r/64959/diff/1/ > > > Testing > ------- > > - verified that V1 REST API for dsl-search and full-text search handle empty > results correctly > - verified that V1 REST API for full-text-search returns correct results > > > Thanks, > > Madhan Neethiraj > >
