> On Jan. 9, 2018, 10:18 p.m., Madhan Neethiraj wrote: > > addons/models/0100-Area1-Collaboration/0150-Feedback.json > > Line 259 (original), 260 (patched) > > <https://reviews.apache.org/r/64982/diff/2/?file=1935555#file1935555line260> > > > > Shouldn't the types be swapped here? "comments" end should have type > > "Comment" and "commentsOn" end should be a Referenceable. Please review.
This looks OK. It is saying that Type referenceable will have an attribute comments. This means that all referencables can have comments. The comments entity can have a relationship to a Referencable - the name of the injected attribute is commentsOn. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64982/#review195084 ----------------------------------------------------------- On Jan. 8, 2018, 5:07 p.m., David Radley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64982/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2018, 5:07 p.m.) > > > Review request for atlas, Madhan Neethiraj and Mandy Chessell. > > > Bugs: 2341 > https://issues.apache.org/jira/browse/2341 > > > Repository: atlas > > > Description > ------- > > While working with the model files - I found that some of the relationship > end names are not unique. I think it is simpler to have these names unique. > This Jira is also used to remove some duplicated relationshipDef > "ProjectScope" and to add an empty attributeDef array for entityDef > "PrivateTag" > > > Diffs > ----- > > addons/models/0100-Area1-Collaboration/0135-Meetings.json 59998be4 > addons/models/0100-Area1-Collaboration/0140-Communities.json e6d7b868 > addons/models/0100-Area1-Collaboration/0150-Feedback.json 0115c64d > > > Diff: https://reviews.apache.org/r/64982/diff/2/ > > > Testing > ------- > > start atlas and make sure the types are as expected using rest calls. > > > Thanks, > > David Radley > >
