----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65100/#review195263 -----------------------------------------------------------
Fix it, then Ship it! webapp/src/main/java/org/apache/atlas/examples/QuickStart.java Line 304 (original), 304 (patched) <https://reviews.apache.org/r/65100/#comment274441> If this change, createEntity(String) ==> createEntity(Referenceable), is not necessary, please revert to using earlier method. webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java Lines 154 (patched) <https://reviews.apache.org/r/65100/#comment274442> Consider handling this special handling of ".isTextual()" inside AtlasJson.toV1Json() and AtlasJson.toJson(). Same for line #281 below. - Madhan Neethiraj On Jan. 11, 2018, 10:11 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65100/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2018, 10:11 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2355 > https://issues.apache.org/jira/browse/ATLAS-2355 > > > Repository: atlas > > > Description > ------- > > Fix IT failures in webapp module > > > Diffs > ----- > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 9176fb99 > client/client-v1/src/main/java/org/apache/atlas/AtlasClient.java ab5bdac0 > webapp/pom.xml 352b8cdf > webapp/src/main/java/org/apache/atlas/examples/QuickStart.java c043b65e > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > b0620937 > webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java > 64a828bc > > webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java > d49391f6 > webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java > 3c5d0318 > webapp/src/test/resources/json/search-parameters/entity-filters.json > 06116444 > > > Diff: https://reviews.apache.org/r/65100/diff/1/ > > > Testing > ------- > > All ITs succeeds in webapp module > > > Thanks, > > Sarath Subramanian > >
