> On Jan. 12, 2018, 12:17 p.m., David Radley wrote: > >
Thanks David for the review. I have made changes as suggested, please review. > On Jan. 12, 2018, 12:17 p.m., David Radley wrote: > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > > Lines 134 (patched) > > <https://reviews.apache.org/r/65121/diff/1/?file=1939372#file1939372line134> > > > > Please could you confirm that thetesting including checking that any > > time interval set here is effective. Set the "atlas.authentication.method.kerberos.token.validity" property to "3600" (seconds, i.e. 1 hour) from Ambari "Custom application-properties". And confirmed that delegation token expiration time is set 1 hour later from current timestamp. > On Jan. 12, 2018, 12:17 p.m., David Radley wrote: > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > > Lines 135 (patched) > > <https://reviews.apache.org/r/65121/diff/1/?file=1939372#file1939372line135> > > > > Shouldn't we validate that this content is a positive integer (I am not > > sure what the highest valid value is - we could check that as well) and > > produce a meaningful error message if it is not valid. Added check for positive number. will throw a Exception incase for NAN - Nixon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65121/#review195307 ----------------------------------------------------------- On Jan. 12, 2018, 11:38 a.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65121/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2018, 11:38 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-2352 > https://issues.apache.org/jira/browse/ATLAS-2352 > > > Repository: atlas > > > Description > ------- > > This patch includes fix to configure validity for Kerberos DelegationToken. > > Property to be added in atlas-application.properties. > > *atlas.authentication.method.kerberos.token.validity*=3600 > > > Diffs > ----- > > docs/src/site/twiki/Authentication-Authorization.twiki 1e35ceb4 > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > e8020dbb > > > Diff: https://reviews.apache.org/r/65121/diff/1/ > > > Testing > ------- > > Kerberos delegation token expiration time is set correctly in hadoop-auth > cookie. > > > Thanks, > > Nixon Rodrigues > >
